[CPU SDP] Remove mem efficient attn checks in CPU #112375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem like memory efficient attention can be used on CPU, as we don't check for it when iterating backends in `select_sdp_backend_cpp`. So removing some of the logic around mem efficient attention. Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: [D50775562](https://our.internmc.facebook.com/intern/diff/D50775562/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D50775562/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112375
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2e774d4 with merge base a26cb0a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rohan-varma
added a commit
that referenced
this pull request
Oct 30, 2023
It doesn't seem like memory efficient attention can be used on CPU, as we don't check for it when iterating backends in `select_sdp_backend_cpp`. So removing some of the logic around mem efficient attention. Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: [D50775562](https://our.internmc.facebook.com/intern/diff/D50775562/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D50775562/)! ghstack-source-id: 205746438 Pull Request resolved: #112375
|
@pytorchbot merge -f "CI done" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
It doesn't seem like memory efficient attention can be used on CPU, as we don't check for it when iterating backends in `select_sdp_backend_cpp`. So removing some of the logic around mem efficient attention selection. Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: [D50775562](https://our.internmc.facebook.com/intern/diff/D50775562/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D50775562/)! Pull Request resolved: pytorch#112375 Approved by: https://github.com/drisspg
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
It doesn't seem like memory efficient attention can be used on CPU, as we don't check for it when iterating backends in `select_sdp_backend_cpp`. So removing some of the logic around mem efficient attention selection. Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: [D50775562](https://our.internmc.facebook.com/intern/diff/D50775562/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D50775562/)! Pull Request resolved: pytorch#112375 Approved by: https://github.com/drisspg
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Nov 19, 2023
It doesn't seem like memory efficient attention can be used on CPU, as we don't check for it when iterating backends in `select_sdp_backend_cpp`. So removing some of the logic around mem efficient attention selection. Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: [D50775562](https://our.internmc.facebook.com/intern/diff/D50775562/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D50775562/)! Pull Request resolved: pytorch#112375 Approved by: https://github.com/drisspg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It doesn't seem like memory efficient attention can be used on CPU, as we don't check for it when iterating backends in
select_sdp_backend_cpp. So removing some of the logic around mem efficient attention selection.Created from CodeHub with https://fburl.com/edit-in-codehub
Differential Revision: D50775562
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!