[Inductor] [Quant] Enable QLinear int8-mixed-bf16 Lowering #112486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112486
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 08aceee with merge base eb15340 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 31, 2023
leslie-fang-intel
added a commit
that referenced
this pull request
Oct 31, 2023
ghstack-source-id: 2dda7766d50b605fb2f636dca6c4826065a459d5 Pull Request resolved: #112486
**Summary** - PR 6 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Oct 31, 2023
ghstack-source-id: efdd491d143e62dff0c001e3e93c25cd413aec9a Pull Request resolved: #112486
**Summary** - PR 6 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 1, 2023
ghstack-source-id: 11d7c513dc9eceaa00cf9040fc19c0a2ab169052 Pull Request resolved: #112486
**Summary** - PR 6 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 1, 2023
ghstack-source-id: 7b02bcb3054439cd276f14bf69d1f5cce96e4e27 Pull Request resolved: #112486
**Summary** - PR 6 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
This was referenced Nov 1, 2023
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 1, 2023
ghstack-source-id: 7b02bcb3054439cd276f14bf69d1f5cce96e4e27 Pull Request resolved: #112486
**Summary** - PR 7 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 2, 2023
ghstack-source-id: 993d1e024cb473d02b1b0d081d3f1b11f2c51ccd Pull Request resolved: #112486
**Summary** - PR 7 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 2, 2023
ghstack-source-id: 602000ad05296e6b255b0e00d72536aec19e26d7 Pull Request resolved: #112486
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 3, 2023
ghstack-source-id: 5dcf1b614cff856f96027bd9b6b1bde2635efd48 Pull Request resolved: #112486
**Summary** - PR 7 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 4, 2023
ghstack-source-id: f761f79300d4759f60d7c72ce553378bfca801b0 Pull Request resolved: #112486
|
Hi @jgong5, please help take look of this PR also. |
jgong5
approved these changes
Nov 6, 2023
eellison
reviewed
Nov 7, 2023
Comment on lines
+1172
to
+1176
| if ( | ||
| len(list(to_fp32_node.users)) != 1 | ||
| or len(list(sub_node.users)) != 1 | ||
| or len(list(mul_node.users)) != 1 | ||
| ): |
There was a problem hiding this comment.
I think you should be able to match this in the pattern.
eellison
approved these changes
Nov 7, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
approved these changes
Nov 9, 2023
**Summary** - PR 7 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 10, 2023
ghstack-source-id: d7da88230a860176f6c1587a4dc435b4b794c13d Pull Request resolved: #112486
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
**Summary** - PR 7 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 10, 2023
ghstack-source-id: 4cde6e5121be8242b92ce943bf6244a6c4a3358a Pull Request resolved: #112486
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…12486) **Summary** - PR 7 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor pytorch#111640. - Enable the QLinear int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qlinear ``` Pull Request resolved: pytorch#112486 Approved by: https://github.com/jgong5, https://github.com/eellison, https://github.com/jerryzh168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
TestPlan
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler