Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTensor] Add rand_like, randn_like, randint_like ops to shard propagation #112576

Closed
wants to merge 5 commits into from
Closed

[DTensor] Add rand_like, randn_like, randint_like ops to shard propagation #112576

wants to merge 5 commits into from

Conversation

joshlk
Copy link
Contributor

@joshlk joshlk commented Nov 1, 2023

Add rand_like, randn_like, randint_like ops to shard propagation

cc: @wanchaol

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 1, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112576

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5fcfa4f with merge base a1ab22b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wanchaol
wanchaol approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some suggestions about dtype

torch/distributed/_tensor/ops/tensor_ops.py Show resolved Hide resolved
test/distributed/_tensor/test_random_ops.py Outdated Show resolved Hide resolved
@joshlk
Copy link
Contributor Author

joshlk commented Nov 2, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 2, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@fduwjj fduwjj added module: dtensor distributed tensor tag release notes: distributed (dtensor) release notes category labels Nov 2, 2023
fduwjj
fduwjj approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the label for you, you can remerge it, it should be super fast.

@joshlk
Copy link
Contributor Author

joshlk commented Nov 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@joshlk @xuhancn
[DTensor] Add rand_like, randn_like, randint_like ops to shard propag…
843b49f 
…ation (pytorch#112576)

Add rand_like, randn_like, randint_like ops to shard propagation

Pull Request resolved: pytorch#112576
Approved by: https://github.com/wanchaol, https://github.com/fduwjj
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@joshlk @Skylion007
[DTensor] Add rand_like, randn_like, randint_like ops to shard propag…
f5669ed 
…ation (pytorch#112576)

Add rand_like, randn_like, randint_like ops to shard propagation

Pull Request resolved: pytorch#112576
Approved by: https://github.com/wanchaol, https://github.com/fduwjj
andreigh pushed a commit to andreigh/pytorch that referenced this pull request Nov 19, 2023
@joshlk @andreigh
[DTensor] Add rand_like, randn_like, randint_like ops to shard propag…
59b8ea0 
…ation (pytorch#112576)

Add rand_like, randn_like, randint_like ops to shard propagation

Pull Request resolved: pytorch#112576
Approved by: https://github.com/wanchaol, https://github.com/fduwjj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fegin fegin Awaiting requested review from fegin

@wz337 wz337 Awaiting requested review from wz337

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dtensor distributed tensor tag open source release notes: distributed (dtensor) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joshlk @pytorchmergebot @fduwjj @wanchaol @pytorchbot