[aotinductor] Allow specifying a .so name in the aot_inductor.output_path config #112651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path config [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112651
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9b189cf with merge base 7f77ec3 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
desertfire
added a commit
that referenced
this pull request
Nov 1, 2023
…path config ghstack-source-id: 15376003077e0bfaa5ce0bc03770392babffe477 Pull Request resolved: #112651
…tor.output_path config" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Nov 1, 2023
…path config ghstack-source-id: f779cb706f3b75d9d64835eafc1dfa2dbf078068 Pull Request resolved: #112651
…tor.output_path config" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Nov 1, 2023
…path config ghstack-source-id: 84a93f0e9e5f54f01857ec2988180c74570118ef Pull Request resolved: #112651
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…tor.output_path config" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler Differential Revision: [D50902585](https://our.internmc.facebook.com/intern/diff/D50902585) [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Nov 2, 2023
…path config ghstack-source-id: db70060220023bd69f9920492e4cb6e7681968f3 Pull Request resolved: #112651
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
chenyang78
approved these changes
Nov 2, 2023
| specified_output_path | ||
| and os.path.dirname(cls.cache[key]) != specified_output_path | ||
| or specified_so_name | ||
| and os.path.basename(cls.cache[key]) != specified_so_name |
There was a problem hiding this comment.
We cache the full path for the output.so, which is either config.aot_inductor.output_path or os.path.splitext(input_path)[0] + ".so". So, seems we wouldn't have any case where we cache specified_so_name?
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 6, 2023
Summary: Some tests can utilize cache_dir() Pull Request resolved: #112728 Approved by: https://github.com/jansel, https://github.com/chenyang78 ghstack dependencies: #112651
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…path config (pytorch#112651) Differential Revision: [D50902585](https://our.internmc.facebook.com/intern/diff/D50902585) Pull Request resolved: pytorch#112651 Approved by: https://github.com/chenyang78
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: Some tests can utilize cache_dir() Pull Request resolved: pytorch#112728 Approved by: https://github.com/jansel, https://github.com/chenyang78 ghstack dependencies: pytorch#112651
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…path config (pytorch#112651) Differential Revision: [D50902585](https://our.internmc.facebook.com/intern/diff/D50902585) Pull Request resolved: pytorch#112651 Approved by: https://github.com/chenyang78
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: Some tests can utilize cache_dir() Pull Request resolved: pytorch#112728 Approved by: https://github.com/jansel, https://github.com/chenyang78 ghstack dependencies: pytorch#112651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler
Differential Revision: D50902585