Fix FSDP summon_full_params(..., with_grads=True) when grad precision is not fp32
#112746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantinjdobler
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung,
d4l3k and
wz337
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112746
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 86f9d5c with merge base 51a3838 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
awgu
approved these changes
Nov 2, 2023
|
I there still a blocker I can resolve? @awgu |
|
@konstantinjdobler Really sorry about this. We can try to land (and rebase if needed). |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
No worries, thanks 🚀 |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…on is not `fp32` (pytorch#112746) Fixes pytorch#112717 I moved the `torch.empty` call after the conditional so that we don't need to check whether `flat_param.grad` is None Pull Request resolved: pytorch#112746 Approved by: https://github.com/awgu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112717
I moved the
torch.emptycall after the conditional so that we don't need to check whetherflat_param.gradis Nonecc @awgu