[FSDP][optim_state_dict] Skip the parameter if the parameter does not belong to the current FSDP instance #112804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… belong to the current FSDP instance Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism. Differential Revision: [D50562170](https://our.internmc.facebook.com/intern/diff/D50562170/) [ghstack-poisoned]
fegin
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fduwjj,
kiukchung,
d4l3k and
wz337
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112804
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 53239d9 with merge base 623a311 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fegin
added a commit
that referenced
this pull request
Nov 2, 2023
… belong to the current FSDP instance Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism. Differential Revision: [D50562170](https://our.internmc.facebook.com/intern/diff/D50562170/) ghstack-source-id: 206330212 Pull Request resolved: #112804
fegin
added
ciflow/trunk
…er does not belong to the current FSDP instance" Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism. Differential Revision: [D50562170](https://our.internmc.facebook.com/intern/diff/D50562170/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Nov 3, 2023
… belong to the current FSDP instance Pull Request resolved: #112804 Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism. ghstack-source-id: 206443558 @exported-using-ghexport Differential Revision: [D50562170](https://our.internmc.facebook.com/intern/diff/D50562170/)
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
… belong to the current FSDP instance (pytorch#112804) Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism. Differential Revision: [D50562170](https://our.internmc.facebook.com/intern/diff/D50562170/) Pull Request resolved: pytorch#112804 Approved by: https://github.com/wz337
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
… belong to the current FSDP instance (pytorch#112804) Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism. Differential Revision: [D50562170](https://our.internmc.facebook.com/intern/diff/D50562170/) Pull Request resolved: pytorch#112804 Approved by: https://github.com/wz337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Skip the fsdp managed parameter if the parameter is not managed by the current FSDP instance. This can happen if the not all FSDP instances have all the parameters. This can happen with FSDP + some MPMD style parallelism.
Differential Revision: D50562170