[state_dict] Add cpu_only and ranks_only support for _gather_state_dict #112836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
fegin
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fduwjj,
wz337,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112836
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9752f60 with merge base 31ded95 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 3, 2023
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
fegin
added
ciflow/trunk
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
wz337
reviewed
Nov 9, 2023
| Args: | ||
| state_dict (Dict[str, Any]): the target sharded state_dict. | ||
| pg (Optional[dist.ProcessGroup]): the process group that is used to | ||
| gather ShardedTensor. |
There was a problem hiding this comment.
nit: gather DTensor or ShardedTensor.
| pg (Optional[dist.ProcessGroup]): the process group that is used to | ||
| gather ShardedTensor. | ||
| device: (Optional[torch.device]): the device that is used to | ||
| perform allgather for ShardedTensor. |
There was a problem hiding this comment.
nit: gather DTensor or ShardedTensor.
There was a problem hiding this comment.
ShardedTensor only. DTensor uses DeviceMesh to gather the tensors.
|
|
||
| new_state_dict[key] = value | ||
| if not cpu_offload or len(ranks_only) == 0 or dist.get_rank(pg) in ranks_only: |
There was a problem hiding this comment.
Maybe the condition is a bit complicated and I can't think thru lol, but is dist.get_rank(pg) in ranks_only alone not sufficient?
There was a problem hiding this comment.
ranks_only can be empty (the default value). But it seems that we should not restrict this function to be cpu_offload only.
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
wz337
approved these changes
Nov 9, 2023
…er_state_dict" Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) [ghstack-poisoned]
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 10, 2023
#112885) This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) Pull Request resolved: #112885 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: #112836
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 13, 2023
…state_dict (#112837) As title Differential Revision: [D50962991](https://our.internmc.facebook.com/intern/diff/D50962991/) Pull Request resolved: #112837 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: #112836, #112885
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ct (pytorch#112836) Add cpu_only and ranks_only support for _gather_state_dict Differential Revision: [D50962980](https://our.internmc.facebook.com/intern/diff/D50962980/) Pull Request resolved: pytorch#112836 Approved by: https://github.com/LucasLLC, https://github.com/wz337
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
pytorch#112885) This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) Pull Request resolved: pytorch#112885 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: pytorch#112836
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…state_dict (pytorch#112837) As title Differential Revision: [D50962991](https://our.internmc.facebook.com/intern/diff/D50962991/) Pull Request resolved: pytorch#112837 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: pytorch#112836, pytorch#112885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add cpu_only and ranks_only support for _gather_state_dict
Differential Revision: D50962980