[Inductor][fx pass] Remove split nodes with split section size one #112922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We observe that DSNN has many split nodes with split section size one, which hinder the split cat merge in the later pass, thus we remove such nodes in the early stage. Test Plan: # local reproduce with DSNN model ``` buck2 run mode/opt //scripts/jackiexu0313/pt2:local_model_with_pt2 -- --test_mode split_batch-group -c ``` P872705076 diffing: https://www.internalfb.com/intern/diffing/?paste_number=872698775 # unit test ``` buck2 test mode/dev-nosan //caffe2/test/inductor:split_cat_fx_passes ``` Buck UI: https://www.internalfb.com/buck2/b248410e-a556-47a2-9293-7f113b49f0d6 Test UI: https://www.internalfb.com/intern/testinfra/testrun/10696049124469023 Network: Up: 80KiB Down: 47KiB (reSessionID-a31dec17-d322-4757-ba84-4d262bd139cf) Jobs completed: 24. Time elapsed: 1:52.8s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 9. Fail 0. Fatal 0. Skip 0. Build failure 0 Differential Revision: D50990290
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112922
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 268cd80 with merge base 63fc482 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50990290 |
This PR needs a
|
jackiexu1992
approved these changes
Nov 6, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ytorch#112922) Summary: We observe that DSNN has many split nodes with split section size one, which hinder the split cat merge in the later pass, thus we remove such nodes in the early stage. Test Plan: # local reproduce with DSNN model ``` buck2 run mode/opt //scripts/jackiexu0313/pt2:local_model_with_pt2 -- --test_mode split_batch-group -c ``` P872705076 diffing: https://www.internalfb.com/intern/diffing/?paste_number=872698775 # unit test ``` buck2 test mode/dev-nosan //caffe2/test/inductor:split_cat_fx_passes ``` Buck UI: https://www.internalfb.com/buck2/b248410e-a556-47a2-9293-7f113b49f0d6 Test UI: https://www.internalfb.com/intern/testinfra/testrun/10696049124469023 Network: Up: 80KiB Down: 47KiB (reSessionID-a31dec17-d322-4757-ba84-4d262bd139cf) Jobs completed: 24. Time elapsed: 1:52.8s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 9. Fail 0. Fatal 0. Skip 0. Build failure 0 Differential Revision: D50990290 Pull Request resolved: pytorch#112922 Approved by: https://github.com/jackiexu1992
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ytorch#112922) Summary: We observe that DSNN has many split nodes with split section size one, which hinder the split cat merge in the later pass, thus we remove such nodes in the early stage. Test Plan: # local reproduce with DSNN model ``` buck2 run mode/opt //scripts/jackiexu0313/pt2:local_model_with_pt2 -- --test_mode split_batch-group -c ``` P872705076 diffing: https://www.internalfb.com/intern/diffing/?paste_number=872698775 # unit test ``` buck2 test mode/dev-nosan //caffe2/test/inductor:split_cat_fx_passes ``` Buck UI: https://www.internalfb.com/buck2/b248410e-a556-47a2-9293-7f113b49f0d6 Test UI: https://www.internalfb.com/intern/testinfra/testrun/10696049124469023 Network: Up: 80KiB Down: 47KiB (reSessionID-a31dec17-d322-4757-ba84-4d262bd139cf) Jobs completed: 24. Time elapsed: 1:52.8s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 9. Fail 0. Fatal 0. Skip 0. Build failure 0 Differential Revision: D50990290 Pull Request resolved: pytorch#112922 Approved by: https://github.com/jackiexu1992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We observe that DSNN has many split nodes with split section size one, which hinder the split cat merge in the later pass, thus we remove such nodes in the early stage.
Test Plan:
local reproduce with DSNN model
P872705076
diffing: https://www.internalfb.com/intern/diffing/?paste_number=872698775
unit test
Buck UI: https://www.internalfb.com/buck2/b248410e-a556-47a2-9293-7f113b49f0d6
Test UI: https://www.internalfb.com/intern/testinfra/testrun/10696049124469023
Network: Up: 80KiB Down: 47KiB (reSessionID-a31dec17-d322-4757-ba84-4d262bd139cf)
Jobs completed: 24. Time elapsed: 1:52.8s.
Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2)
Tests finished: Pass 9. Fail 0. Fatal 0. Skip 0. Build failure 0
Differential Revision: D50990290
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler