New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file name and size to the serialization metadata logging #113077

Closed

atannous wants to merge 1 commit into pytorch:main from atannous:export-D51040426

Contributor

atannous commented Nov 6, 2023

Summary:
To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.

file_name
file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

pytorch-bot bot added the release notes: package/deploy label

pytorch-bot bot commented Nov 6, 2023 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113077

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d94ff21 with merge base e138d80 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Nov 6, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

facebook-github-bot added the fb-exported label

atannous force-pushed the export-D51040426 branch from d8f0ea3 to 06127eb Compare

November 6, 2023 23:03

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

06127eb

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from 06127eb to 52033fa Compare

November 6, 2023 23:03

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

52033fa

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

Contributor

facebook-github-bot commented Nov 6, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

2 similar comments

Contributor

facebook-github-bot commented Nov 6, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

Contributor

facebook-github-bot commented Nov 6, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from 52033fa to 7ac93c8 Compare

November 6, 2023 23:16

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

7ac93c8

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from 7ac93c8 to 5344956 Compare

November 7, 2023 06:55

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from 5344956 to e732f7f Compare

November 7, 2023 07:02

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

e732f7f

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous requested review from davidberard98 and suo

November 7, 2023 16:51

davidberard98 approved these changes

View reviewed changes

Contributor

davidberard98 left a comment

LGTM as long as tests pass

Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from e732f7f to c938c60 Compare

November 7, 2023 23:01

Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

c938c60

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from c938c60 to df6b6f0 Compare

November 8, 2023 04:40

Contributor

facebook-github-bot commented Nov 8, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

df6b6f0

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426


          Add file name and size to the serialization metadata logging (pytorch…

d94ff21

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from df6b6f0 to d2adbc5 Compare

November 8, 2023 18:38

atannous added a commit to atannous/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

d2adbc5

…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

Contributor

facebook-github-bot commented Nov 8, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

atannous force-pushed the export-D51040426 branch from d2adbc5 to d94ff21 Compare

November 8, 2023 18:38

Contributor

facebook-github-bot commented Nov 8, 2023

This pull request was exported from Phabricator. Differential Revision: D51040426

Contributor

facebook-github-bot commented Nov 9, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Nov 9, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot removed the merging label

pytorchmergebot closed this in

be66d5e

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request


          Add file name and size to the serialization metadata logging (pytorch…

f44d762

…#113077)

Summary:
To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

Pull Request resolved: pytorch#113077
Approved by: https://github.com/davidberard98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment