Make FakeProcessGroup traceable #113314
Closed
Make FakeProcessGroup traceable #113314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR mimics what we have done to trace ProcessGroup. Differential Revision: [D51136463](https://our.internmc.facebook.com/intern/diff/D51136463/) [ghstack-poisoned]
fegin
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fduwjj,
wz337 and
LucasLLC
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113314
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 858ef91 with merge base 376217c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fegin
added a commit
that referenced
this pull request
Nov 8, 2023
This PR mimics what we have done to trace ProcessGroup. Differential Revision: [D51136463](https://our.internmc.facebook.com/intern/diff/D51136463/) ghstack-source-id: 206942938 Pull Request resolved: #113314
wanchaol
reviewed
Nov 8, 2023
torch/_dynamo/variables/builder.py
Outdated
| @@ -660,6 +661,12 @@ def index_source(key): | |||
| source=self.source, | |||
| guards=self.make_guards(GuardBuilder.ID_MATCH), | |||
| ) | |||
| elif FakeProcessGroupVariable.is_process_group(value): | |||
There was a problem hiding this comment.
could we make this check directly inside ProcessGroupVariable, I think FakePG is just another type of PG so we should try to make that works directly
There was a problem hiding this comment.
Good point. I guess we won't actually do something special for FakePG. Let me change it.
This PR mimics what we have done to trace ProcessGroup. This allows use to use FakeProcessGroup with torch.compile. FakeProcessGroup allows us to use world_size > 1 without creating multiple processes thus enabling the usage of PDB to debug bucketing DDP allreduce in the Inductor. We can theoretically use GLOO with world_size==1 to achieve the same goal. However, the `wait()` seems to be optimized away when the world_size is 1. Differential Revision: [D51136463](https://our.internmc.facebook.com/intern/diff/D51136463/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Nov 9, 2023
Pull Request resolved: #113314 This PR mimics what we have done to trace ProcessGroup. This allows use to use FakeProcessGroup with torch.compile. FakeProcessGroup allows us to use world_size > 1 without creating multiple processes thus enabling the usage of PDB to debug bucketing DDP allreduce in the Inductor. We can theoretically use GLOO with world_size==1 to achieve the same goal. However, the `wait()` seems to be optimized away when the world_size is 1. ghstack-source-id: 206958093 @exported-using-ghexport Differential Revision: [D51136463](https://our.internmc.facebook.com/intern/diff/D51136463/)
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
This PR mimics what we have done to trace ProcessGroup. This allows use to use FakeProcessGroup with torch.compile. FakeProcessGroup allows us to use world_size > 1 without creating multiple processes thus enabling the usage of PDB to debug bucketing DDP allreduce in the Inductor. We can theoretically use GLOO with world_size==1 to achieve the same goal. However, the `wait()` seems to be optimized away when the world_size is 1. Differential Revision: [D51136463](https://our.internmc.facebook.com/intern/diff/D51136463/) Pull Request resolved: pytorch#113314 Approved by: https://github.com/wanchaol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR mimics what we have done to trace ProcessGroup. This allows use to use FakeProcessGroup with torch.compile. FakeProcessGroup allows us to use world_size > 1 without creating multiple processes thus enabling the usage of PDB to debug bucketing DDP allreduce in the Inductor. We can theoretically use GLOO with world_size==1 to achieve the same goal. However, the
wait()seems to be optimized away when the world_size is 1.Differential Revision: D51136463
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng