Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kineto] Fix the Chrome trace loading issue with all_to_all input split length > 30 #113392

Closed
wants to merge 1 commit into from

Commits on Nov 9, 2023

  1. [Kineto] Fix the Chrome trace loading issue with all_to_all input spl…

    …it length > 30 (pytorch#113392)
    
    Summary:
    
    This change fixes the Chrome trace loading issue with all_to_all input split length > 30.
    
    Now when the `all_to_all` input split size is larger than 30 we truncate the content and adding `...` at the end, which caused trouble when loading with Chrome trace.
    
    Test Plan:
    **Trace with length = 2**:
    - Link: https://fburl.com/perfdoctor/b94u4x82
     {F1145436735}
    
    **Looking into the json file**:
    ```
    Before:
    "In split size": [6058496, 5942784]
    
    After
    "In split size": "[6058496, 5942784]"
    ```
     {F1145551691}
    
    Reviewed By: aaronenyeshi
    
    Differential Revision: D51167843
    yoyoyocmu authored and facebook-github-bot committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e0ea3ef View commit details
    Browse the repository at this point in the history