Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kineto] Fix the Chrome trace loading issue with all_to_all input split length > 30 #113392

Closed
wants to merge 1 commit into from
Closed

[Kineto] Fix the Chrome trace loading issue with all_to_all input split length > 30 #113392

wants to merge 1 commit into from

Conversation

yoyoyocmu
Copy link
Contributor

Summary:
This change fixes the Chrome trace loading issue with all_to_all input split length > 30.

Now when the all_to_all input split size is larger than 30 we truncate the content and adding ... at the end, which caused trouble when loading with Chrome trace.

Test Plan:
Trace with length = 2:

Looking into the json file:

Before:
"In split size": [6058496, 5942784]

After
"In split size": "[6058496, 5942784]"

Reviewed By: aaronenyeshi

Differential Revision: D51167843

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 9, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113392

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e0ea3ef with merge base bb06725 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51167843

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@yoyoyocmu @facebook-github-bot
[Kineto] Fix the Chrome trace loading issue with all_to_all input spl…
e0ea3ef 
…it length > 30 (pytorch#113392)

Summary:

This change fixes the Chrome trace loading issue with all_to_all input split length > 30.

Now when the `all_to_all` input split size is larger than 30 we truncate the content and adding `...` at the end, which caused trouble when loading with Chrome trace.

Test Plan:
**Trace with length = 2**:
- Link: https://fburl.com/perfdoctor/b94u4x82
 {F1145436735}

**Looking into the json file**:
```
Before:
"In split size": [6058496, 5942784]

After
"In split size": "[6058496, 5942784]"
```
 {F1145551691}

Reviewed By: aaronenyeshi

Differential Revision: D51167843
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51167843

aaronenyeshi
aaronenyeshi approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@yoyoyocmu @Skylion007
[Kineto] Fix the Chrome trace loading issue with all_to_all input spl…
d5f950a 
…it length > 30 (pytorch#113392)

Summary:
This change fixes the Chrome trace loading issue with all_to_all input split length > 30.

Now when the `all_to_all` input split size is larger than 30 we truncate the content and adding `...` at the end, which caused trouble when loading with Chrome trace.

Test Plan:
**Trace with length = 2**:
- Link: https://fburl.com/perfdoctor/b94u4x82
 {F1145436735}

**Looking into the json file**:
```
Before:
"In split size": [6058496, 5942784]

After
"In split size": "[6058496, 5942784]"
```

Reviewed By: aaronenyeshi

Differential Revision: D51167843

Pull Request resolved: pytorch#113392
Approved by: https://github.com/aaronenyeshi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoyoyocmu @facebook-github-bot @pytorchmergebot @aaronenyeshi