[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

desertfire · 2023-11-14T17:35:43Z

Stack from ghstack (oldest at bottom):

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

Differential Revision: D51382677

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. [ghstack-poisoned]

pytorch-bot · 2023-11-14T17:35:46Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113660

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93482e7 with merge base cebad98 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. ghstack-source-id: 07d4e9cd3d0d54be3d9b60520cfa0b3d0aaff7d3 Pull Request resolved: #113660

…degen time" Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. ghstack-source-id: b9b1aea254746656d1644a4c20a76ca87e3fc7e4 Pull Request resolved: #113660

…degen time" Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. ghstack-source-id: 566a03588604a84cc97f0ec85955e5069020a996 Pull Request resolved: #113660

…degen time" Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]

chenyang78 · 2023-11-16T00:32:51Z

torch/_inductor/ir.py

@@ -4015,10 +4028,10 @@ def codegen(self, wrapper):
        wrapper.generate_scatter_fallback(
            x,
            [x, self.constant_args[0], index, src],
-            self.kernel,
+            self.cpp_kernel if V.graph.cpp_wrapper else self.kernel,


Can we call self.codegen_kernel_name here?

This is because codegen_kernel_name doesn't exist in the base class ExternKernel, since not all ExternKernel has a kernel name. I think @int3 raised a similar question in a different context, codegen_kwargs. I will create some other PRs to do some refactoring to the base/child classes here.

chenyang78 · 2023-11-16T00:33:24Z

torch/_inductor/ir.py

-        wrapper.writeline(wrapper.wrap_kernel_call(self.kernel, args))
+        wrapper.writeline(
+            wrapper.wrap_kernel_call(
+                self.cpp_kernel if V.graph.cpp_wrapper else self.kernel, args


ditto - can we call self.codegen_kernel_name?

chenyang78 · 2023-11-16T00:33:49Z

torch/_inductor/ir.py

@@ -4925,7 +4936,7 @@ def __init__(
    def codegen(self, wrapper):
        wrapper.generate_extern_kernel_alloc_and_find_schema_if_needed(
            self.get_name(),
-            self.kernel,
+            self.cpp_kernel if V.graph.cpp_wrapper else self.kernel,


chenyang78 · 2023-11-16T00:34:04Z

torch/_inductor/ir.py

@@ -3718,7 +3718,7 @@ def codegen(self, wrapper):
            self.output_view,
            self.codegen_reference(),
            args,
-            self.kernel,
+            self.cpp_kernel if V.graph.cpp_wrapper else self.kernel,


desertfire · 2023-11-16T01:51:13Z

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

chenyang78

LGTM. Thanks!

…degen time" Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler Differential Revision: [D51382677](https://our.internmc.facebook.com/intern/diff/D51382677) [ghstack-poisoned]

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. ghstack-source-id: af31f1e7a7928beef0b0f0b87c6fa9291321082a Pull Request resolved: #113660

desertfire · 2023-11-16T13:33:14Z

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…degen time" Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler Differential Revision: [D51382677](https://our.internmc.facebook.com/intern/diff/D51382677) [ghstack-poisoned]

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. ghstack-source-id: bb7bce66e6389b927d2872016a760d082b995692 Pull Request resolved: #113660

desertfire · 2023-11-16T13:53:18Z

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-11-16T23:05:38Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2023-11-16T23:07:19Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[AOTI] Delay the fallback kernel naming decision to the codegen time

52cb255

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only. [ghstack-poisoned]

This was referenced Nov 14, 2023

[AOTI] Refactor the code for checking device info #113616

Closed

[AOTI] Remove try_find_schema #113617

Closed

github-actions bot added module: inductor ciflow/inductor labels Nov 14, 2023

desertfire added the topic: not user facing topic category label Nov 14, 2023

desertfire mentioned this pull request Nov 15, 2023

[AOTI] Improve the two-pass wrapper codegen #113762

Closed

desertfire requested review from jansel, SherlockNoMad, chenyang78 and muchulee8 November 15, 2023 21:15

chenyang78 reviewed Nov 16, 2023

View reviewed changes

chenyang78 approved these changes Nov 16, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 16, 2023

pytorchmergebot added the merging label Nov 16, 2023

pytorchmergebot added the Merged label Nov 16, 2023

pytorchmergebot removed the merging label Nov 16, 2023

pytorchmergebot closed this in 1480c67 Nov 16, 2023

facebook-github-bot deleted the gh/desertfire/265/head branch November 20, 2023 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

desertfire commented Nov 14, 2023 •

edited

pytorch-bot bot commented Nov 14, 2023 •

edited

chenyang78 Nov 16, 2023

desertfire Nov 16, 2023

chenyang78 Nov 16, 2023

chenyang78 Nov 16, 2023

chenyang78 Nov 16, 2023

desertfire commented Nov 16, 2023

chenyang78 left a comment

desertfire commented Nov 16, 2023

desertfire commented Nov 16, 2023

facebook-github-bot commented Nov 16, 2023

pytorchmergebot commented Nov 16, 2023

[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

Conversation

desertfire commented Nov 14, 2023 • edited

pytorch-bot bot commented Nov 14, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113660

✅ No Failures

chenyang78 Nov 16, 2023

Choose a reason for hiding this comment

desertfire Nov 16, 2023

Choose a reason for hiding this comment

chenyang78 Nov 16, 2023

Choose a reason for hiding this comment

chenyang78 Nov 16, 2023

Choose a reason for hiding this comment

chenyang78 Nov 16, 2023

Choose a reason for hiding this comment

desertfire commented Nov 16, 2023

chenyang78 left a comment

Choose a reason for hiding this comment

desertfire commented Nov 16, 2023

desertfire commented Nov 16, 2023

facebook-github-bot commented Nov 16, 2023

pytorchmergebot commented Nov 16, 2023

Merge started

desertfire commented Nov 14, 2023 •

edited

pytorch-bot bot commented Nov 14, 2023 •

edited