[AOTI] Remove try_find_schema #113617
[AOTI] Remove try_find_schema #113617
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113617
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 69e2afa with merge base 9146ca6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| # For cpp wrapper, when kwargs is not empty, for OpOverloadPacket kernel, we need to | ||
| # know the exact overload schema to handle the kwargs properly when calling the cpp kernel. | ||
| if ( | ||
| V.graph.cpp_wrapper | ||
| and kwargs | ||
| and isinstance(kernel, torch._ops.OpOverloadPacket) | ||
| ): | ||
| schema = try_find_schema(schemas, args, kwargs) |
There was a problem hiding this comment.
I remember, this was needed to find the right schema for torch.repeat_interleave.Tensor. Do we no longer need this?
There was a problem hiding this comment.
Right, because Sherlock's #111396 has made sure we will only see OpOverload at this point.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
Summary: try_find_schema is not needed since we don't allow OpOverloadPacket for fallback ops now. Also refactor relevant code for simplification. ghstack-source-id: b71afc942ee0bf893c81a2ceb6d716ddc04d11a4 Pull Request resolved: #113617
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler
Differential Revision: D51350727