Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quant] [PT2] Add Hardtanh and ReLU6 into X86InductorQuantizer Conv2d Unary Annotation #114579

Conversation

leslie-fang-intel
Copy link
Collaborator

@leslie-fang-intel leslie-fang-intel commented Nov 27, 2023

Stack from ghstack (oldest at bottom):

Summary
Add Hardtanh and ReLU6 into X86InductorQuantizer Conv2d Unary Annotation

TestPlan

python -m pytest test_x86inductor_quantizer.py -k test_conv2d_unary
python -m pytest test_x86inductor_quantizer.py -k test_qat_conv2d_unary

Copy link

pytorch-bot bot commented Nov 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114579

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac913e8 with merge base 11f11e9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Nov 27, 2023
@leslie-fang-intel leslie-fang-intel changed the title Add Hardtanh and ReLU6 into X86InductorQuantizer Conv2d Unary post op Add Hardtanh and ReLU6 into X86InductorQuantizer Conv2d Unary Annotation Nov 27, 2023
@leslie-fang-intel leslie-fang-intel changed the title Add Hardtanh and ReLU6 into X86InductorQuantizer Conv2d Unary Annotation [Quant] [PT2] Add Hardtanh and ReLU6 into X86InductorQuantizer Conv2d Unary Annotation Nov 27, 2023
@leslie-fang-intel leslie-fang-intel added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 27, 2023
leslie-fang-intel added a commit to leslie-fang-intel/pytorch that referenced this pull request Nov 27, 2023
ghstack-source-id: 719d24ffda671ed0c70a11c85e9119b6caa1c425
Pull Request resolved: pytorch#114579
…izer Conv2d Unary Annotation"


**Summary**
Add `Hardtanh` and `ReLU6` into X86InductorQuantizer Conv2d Unary Annotation

**TestPlan**
```
python -m pytest test_x86inductor_quantizer.py -k test_conv2d_unary
python -m pytest test_x86inductor_quantizer.py -k test_qat_conv2d_unary
```




[ghstack-poisoned]
leslie-fang-intel added a commit to leslie-fang-intel/pytorch that referenced this pull request Nov 27, 2023
ghstack-source-id: d84ce1494ddac824adf30a6736dfb7cbbf936839
Pull Request resolved: pytorch#114579
…izer Conv2d Unary Annotation"


**Summary**
Add `Hardtanh` and `ReLU6` into X86InductorQuantizer Conv2d Unary Annotation

**TestPlan**
```
python -m pytest test_x86inductor_quantizer.py -k test_conv2d_unary
python -m pytest test_x86inductor_quantizer.py -k test_qat_conv2d_unary
```




[ghstack-poisoned]
leslie-fang-intel added a commit to leslie-fang-intel/pytorch that referenced this pull request Nov 28, 2023
ghstack-source-id: b4d21b0d0438a2c34b1e851a20029a05e8bb2b5e
Pull Request resolved: pytorch#114579
…izer Conv2d Unary Annotation"


**Summary**
Add `Hardtanh` and `ReLU6` into X86InductorQuantizer Conv2d Unary Annotation

**TestPlan**
```
python -m pytest test_x86inductor_quantizer.py -k test_conv2d_unary
python -m pytest test_x86inductor_quantizer.py -k test_qat_conv2d_unary
```




[ghstack-poisoned]
leslie-fang-intel added a commit to leslie-fang-intel/pytorch that referenced this pull request Nov 28, 2023
ghstack-source-id: 3ca1fb17ffe7f807c742eb164afb69fb54d38289
Pull Request resolved: pytorch#114579
@leslie-fang-intel
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 28, 2023
…rdtanh (#114580)

**Summary**
Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator.

**Test Plan**
```
python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu
python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu

python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6
python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh
```

Pull Request resolved: #114580
Approved by: https://github.com/jgong5, https://github.com/jerryzh168
ghstack dependencies: #114578, #114579
vfdev-5 pushed a commit to vfdev-5/pytorch that referenced this pull request Nov 29, 2023
… Unary Annotation (pytorch#114579)

**Summary**
Add `Hardtanh` and `ReLU6` into X86InductorQuantizer Conv2d Unary Annotation

**TestPlan**
```
python -m pytest test_x86inductor_quantizer.py -k test_conv2d_unary
python -m pytest test_x86inductor_quantizer.py -k test_qat_conv2d_unary
```

Pull Request resolved: pytorch#114579
Approved by: https://github.com/jgong5, https://github.com/jerryzh168
ghstack dependencies: pytorch#114578
vfdev-5 pushed a commit to vfdev-5/pytorch that referenced this pull request Nov 29, 2023
…rdtanh (pytorch#114580)

**Summary**
Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator.

**Test Plan**
```
python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu
python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu

python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6
python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh
```

Pull Request resolved: pytorch#114580
Approved by: https://github.com/jgong5, https://github.com/jerryzh168
ghstack dependencies: pytorch#114578, pytorch#114579
@facebook-github-bot facebook-github-bot deleted the gh/leslie-fang-intel/50/head branch December 1, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: quantization release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants