[Quant] [Inductor] Enable the Inductor Lowering of QConv2d post op hardtanh #114580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114580
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 656a829 with merge base 11f11e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 27, 2023
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 27, 2023
ghstack-source-id: ccb9faa970d6b7b2eb00ceff7b88c583f56bbb74 Pull Request resolved: #114580
leslie-fang-intel
changed the title
jgong5
reviewed
Nov 27, 2023
… post op hardtanh" **Summary** Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator. **Test Plan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6 python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 27, 2023
ghstack-source-id: e5623040cf0423133d35d0dae21beae307444195 Pull Request resolved: #114580
jgong5
approved these changes
Nov 27, 2023
jerryzh168
approved these changes
Nov 27, 2023
… post op hardtanh" **Summary** Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator. **Test Plan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6 python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Nov 28, 2023
ghstack-source-id: ecc8e9434ffd69a36440b0cb9d5a4f72f766adc5 Pull Request resolved: #114580
… post op hardtanh" **Summary** Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator. **Test Plan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6 python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Nov 28, 2023
ghstack-source-id: bf41d5c1a7198395f3104017632fbc850606ffb3 Pull Request resolved: pytorch#114580
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
vfdev-5
pushed a commit
to vfdev-5/pytorch
that referenced
this pull request
Nov 29, 2023
…rdtanh (pytorch#114580) **Summary** Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator. **Test Plan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6 python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh ``` Pull Request resolved: pytorch#114580 Approved by: https://github.com/jgong5, https://github.com/jerryzh168 ghstack dependencies: pytorch#114578, pytorch#114579
|
@pytorchbot merge |
|
Can't merge closed PR #114580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Enable the fusion pattern of
QConv2d -> hardtanhlowering tohardtanhasQConv2dpost operator.Test Plan
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler