Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Trition pin #115743

Closed
wants to merge 6 commits into from
Closed

Update Trition pin #115743

wants to merge 6 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 13, 2023 •
edited
Loading

To include a cherry-pick of triton-lang/triton#2771 that should fix cuda-11.8 runtime issues

Also, tweak build wheel script to update both ROCm and vanilla Trition builds version to 2.2 (even though on trunk it should probably be 3.3 already)

TODO: Remove ROCM_TRITION_VERSION once both trunk and ROCM version are in sync again

@malfet
[Release/2.2] Update Trition pin
ee0eb06 
To include a cherry-pick of triton-lang/triton#2771 that should fix  cuda-11.8 runtime issues
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 13, 2023
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115743

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0be5591 with merge base 310f6ab (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Dec 13, 2023
@malfet malfet changed the title [Release/2.2] Update Trition pin Update Trition pin Dec 14, 2023
@malfet malfet requested a review from a team as a code owner December 14, 2023 01:16
@malfet
Copy link
Contributor Author

malfet commented Dec 14, 2023

@pytorchbot merge -f "Triton builds are green as well as inductor workflows, binarybuilds is a chicken and egg problem"

@malfet
Copy link
Contributor Author

malfet commented Dec 14, 2023

Inductor builds are green for the initial version of the PR, see https://github.com/pytorch/pytorch/actions/runs/7198184572/job/19610687334 and https://github.com/pytorch/pytorch/actions/runs/7198184581/job/19607037243

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
@malfet @guilhermeleobas
Update Trition pin (pytorch#115743)
dec6b31 
To include a cherry-pick of triton-lang/triton#2771 that should fix  cuda-11.8 runtime issues

Also, tweak build wheel script to update both ROCm and vanilla Trition builds version to 2.2 (even though on trunk it should probably be 3.3 already)

TODO: Remove `ROCM_TRITION_VERSION` once both trunk and ROCM version are in sync again

Pull Request resolved: pytorch#115743
Approved by: https://github.com/davidberard98
@malfet malfet deleted the malfet-patch-26 branch December 18, 2023 19:04
@huydhn huydhn mentioned this pull request Dec 18, 2023
Merged
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@malfet @dmenig
Update Trition pin (pytorch#115743)
559d423 
To include a cherry-pick of triton-lang/triton#2771 that should fix  cuda-11.8 runtime issues

Also, tweak build wheel script to update both ROCm and vanilla Trition builds version to 2.2 (even though on trunk it should probably be 3.3 already)

TODO: Remove `ROCM_TRITION_VERSION` once both trunk and ROCM version are in sync again

Pull Request resolved: pytorch#115743
Approved by: https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 approved these changes

@desertfire desertfire Awaiting requested review from desertfire desertfire is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

@eellison eellison Awaiting requested review from eellison eellison is a code owner

@shunting314 shunting314 Awaiting requested review from shunting314 shunting314 is a code owner

@bertmaher bertmaher Awaiting requested review from bertmaher bertmaher is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony is a code owner

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @pytorchmergebot @davidberard98