Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Improve check and report of Magma #117858

Closed
wants to merge 1 commit into from
Closed

CMake: Improve check and report of Magma #117858

wants to merge 1 commit into from

Conversation

Flamefire
Copy link
Collaborator

@Flamefire Flamefire commented Jan 19, 2024 •
edited by pytorch-bot bot
Loading

  • Only search for magma if it is used (GPU builds)
  • Don't report it was not found when it isn't searched for
  • Don't report if magma is disabled (currently: "MAGMA not found. Compiling without MAGMA support" is reported)

cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jan 19, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117858

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 40531f4 with merge base 79655a1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Jan 19, 2024
@cpuhrsch cpuhrsch requested a review from malfet January 20, 2024 04:42
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 20, 2024
malfet
malfet approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good do me, but I wonder if it'll be better to make USE_MAGMA and cmake_dependent_option in

pytorch/CMakeLists.txt

Line 227 in bad5e1e

option(USE_MAGMA "Use MAGMA" ON)

@Flamefire
Copy link
Collaborator Author

Makes sense yes, but that would be a possible behavior change I didn't want to introduce here. And with this change the change to dependent option is easy and much more obvious: Basically delete the if(USE_CUDA OR USE_ROCM) and the else branch from this part of the code.

@thiagocrepaldi thiagocrepaldi removed the release notes: onnx torch.onnx related changes that should show up in the release notes label Jan 25, 2024
thiagocrepaldi
thiagocrepaldi reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet Not sure why it had the release notes: onnx label in it, but LGTM

@Skylion007
Copy link
Collaborator

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 15, 2024
@Skylion007 Skylion007 added the topic: not user facing topic category label May 15, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@Flamefire @pytorchmergebot
CMake: Improve check and report of Magma
40531f4 
- Only search for magma if it is used (GPU builds)
- Don't report it was not found when it isn't searched for
- Don't report if magma is disabled
@pytorchmergebot
Copy link
Collaborator

Successfully rebased improve-use-magma onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout improve-use-magma && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Flamefire Flamefire deleted the improve-use-magma branch May 16, 2024 14:49
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@Flamefire @ZelboK
CMake: Improve check and report of Magma (pytorch#117858)
35117bf 
- Only search for magma if it is used (GPU builds)
- Don't report it was not found when it isn't searched for
- Don't report if magma is disabled (currently: "MAGMA not found. Compiling without MAGMA support" is reported)

Pull Request resolved: pytorch#117858
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocrepaldi thiagocrepaldi thiagocrepaldi left review comments

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Flamefire @Skylion007 @pytorchmergebot @malfet @thiagocrepaldi @cpuhrsch @pytorchbot