New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable x86 CPU vectorization on windows [submodule sleef] #118980
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118980
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 4336fb0 with merge base a001b4b (): NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot label "topic: not user facing" |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: .github/workflows/pull.yml / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
merge PR avoid code getting stale, @huydhn please update fb_code sleef to shibatch/sleef@60e76d2, it should be works well. CC: @malfet |
@pytorchbot revert -m "Breaks internal build" -c ghfirst |
Please note multiple jobs are broken. here are some of the errors:
|
@pytorchbot successfully started a revert job. Check the current status here. |
…18980)" This reverts commit d94db5f. Reverted #118980 on behalf of https://github.com/atalman due to Breaks internal build ([comment](#118980 (comment)))
@xuhancn your PR has been successfully reverted. |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm6.0-py3.8 / build Details for Dev Infra teamRaised by workflow job |
@pytorchmergebot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: pull / linux-jammy-py3.8-gcc11 / test (default, 2, 3, linux.2xlarge), pull / linux-jammy-py3.8-gcc11 / test (default, 3, 3, linux.2xlarge), linux-binary-libtorch-cxx11-abi / libtorch-rocm6_0-shared-with-deps-cxx11-abi-build / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@atalman I'm importing the sleef module to unblocking this internally, I have the diff to import sleef at D55567582. We can rebase this on top to see if it fixes the build issue. |
…torch#118980)" This reverts commit 56451cd.
…8980) Enable VEC on Windows OS. 1. Fix some type defination gap between Windows and Linux. 2. Fix some operator not support on Windows, such as [], /. 3. Enable static sleef library build on Windows. 4. Disable unsupported function overloading on MSVC. 5. Upgrade submodule sleef lib, which fixed build issue on Windows. 6. Fixed bazel build issues. 7. Fix test app not link to sleef on Windows. Note: If rebuild fail after pulled this PR, please sync `sleef` submodule by run: ```cmd git submodule sync git submodule update --init --recursive ``` Pull Request resolved: pytorch#118980 Approved by: https://github.com/jgong5, https://github.com/ezyang, https://github.com/malfet
Subsequent PR to #118980, fix sleef build warning. submodule sleef, include this sleef PR: shibatch/sleef#514 Pull Request resolved: #122168 Approved by: https://github.com/jgong5, https://github.com/ezyang
…18980)" This reverts commit 2b06098. Reverted #118980 on behalf of https://github.com/zou3519 due to This caused build failures for 2+ pytorch devs, so we're reverting it to be safe ([comment](#118980 (comment)))
…torch#118980)" This reverts commit d94db5f. Reverted pytorch#118980 on behalf of https://github.com/atalman due to Breaks internal build ([comment](pytorch#118980 (comment)))
…8980) Enable VEC on Windows OS. 1. Fix some type defination gap between Windows and Linux. 2. Fix some operator not support on Windows, such as [], /. 3. Enable static sleef library build on Windows. 4. Disable unsupported function overloading on MSVC. 5. Upgrade submodule sleef lib, which fixed build issue on Windows. 6. Fixed bazel build issues. 7. Fix test app not link to sleef on Windows. Note: If rebuild fail after pulled this PR, please sync `sleef` submodule by run: ```cmd git submodule sync git submodule update --init --recursive ``` Pull Request resolved: pytorch#118980 Approved by: https://github.com/jgong5, https://github.com/ezyang, https://github.com/malfet
Enable VEC on Windows OS. 1. Fix some type defination gap between Windows and Linux. 2. Fix some operator not support on Windows, such as [], /. 3. Enable static sleef library build on Windows. 4. Disable unsupported function overloading on MSVC. 5. Upgrade submodule sleef lib, which fixed build issue on Windows. 6. Fixed bazel build issues. 7. Fix test app not link to sleef on Windows. Pull Request resolved: #118980 Approved by: https://github.com/jgong5, https://github.com/ezyang, https://github.com/malfet
…18980)" This reverts commit aa74a8b. Reverted #118980 on behalf of https://github.com/huydhn due to Sorry for revert your change one more time but the hard part is that it breaks lot of internal builds ([comment](#118980 (comment)))
…ytorch#118980)" This reverts commit 7e3fc10.
Enable VEC on Windows OS.
Note: If rebuild fail after pulled this PR, please sync
sleef
submodule by run:cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @frank-wei