Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disable fp contractions warning on msvc #514

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix disable fp contractions warning on msvc #514

merged 2 commits into from
Mar 18, 2024

Conversation

xuhancn
Copy link
Contributor

@xuhancn xuhancn commented Feb 12, 2024 •
edited

Warning message on MSVC:

28>D:\xu_github\sleef\src\libm\sleefsimddp.c(28,9): warning C4068: unknown pragma 'STDC'
28>sleefsimdsp.c
28>D:\xu_github\sleef\src\libm\sleefsimdsp.c(28,9): warning C4068: unknown pragma 'STDC'
28>Generating Code...

Fix it by conditional defination for disable fp contractions.

@xuhancn xuhancn force-pushed the fix_disable_fp_contractions_warning_on_msvc branch from bf7b4e3 to f48c007 Compare February 12, 2024 17:41
@xuhancn xuhancn force-pushed the fix_disable_fp_contractions_warning_on_msvc branch from f48c007 to cf99afd Compare February 12, 2024 17:45
@xuhancn xuhancn marked this pull request as ready for review February 12, 2024 17:45
@blapie
Copy link
Collaborator

blapie commented Mar 4, 2024

Thank you! Would you mind doing the same modification for sleefsp.c and sleefdp.c?
Other occurrences of this pattern are
src/libm/sleefinline_header.h.org
src/quad/sleefsimdqp.c
src/quad/sleefquadinline_header.h.org
and
src/quad/sleefquadinline_cuda_header.h.org

@xuhancn
Copy link
Contributor Author

xuhancn commented Mar 6, 2024 •
edited

Thank you! Would you mind doing the same modification for sleefsp.c and sleefdp.c? Other occurrences of this pattern are src/libm/sleefinline_header.h.org src/quad/sleefsimdqp.c src/quad/sleefquadinline_header.h.org and src/quad/sleefquadinline_cuda_header.h.org

Done the fixing for above files. Thanks. @blapie

@blapie blapie merged commit 36907bb into shibatch:master Mar 18, 2024
31 checks passed
@xuhancn xuhancn mentioned this pull request Mar 19, 2024
Closed
@xuhancn xuhancn deleted the fix_disable_fp_contractions_warning_on_msvc branch March 19, 2024 05:19
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Mar 20, 2024
@xuhancn @pytorchmergebot
Upgrade submodule sleef to fix build warning (#122168)
eec8b25 
Subsequent PR to #118980, fix sleef build warning.

submodule sleef, include this sleef PR: shibatch/sleef#514

Pull Request resolved: #122168
Approved by: https://github.com/jgong5, https://github.com/ezyang
pytorch-bot bot pushed a commit to pytorch/pytorch that referenced this pull request Apr 22, 2024
@xuhancn
Upgrade submodule sleef to fix build warning (#122168)
55a9d36 
Subsequent PR to #118980, fix sleef build warning.

submodule sleef, include this sleef PR: shibatch/sleef#514

Pull Request resolved: #122168
Approved by: https://github.com/jgong5, https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xuhancn @blapie