New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPP] Update GCC minversion check to 9 or newer #120126
Conversation
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 10.x, as clang-5 is clearly not C++17 compliant Fixes #120020
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120126
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 7e45701 with merge base 637cf4a (): BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes pytorch#120020 Pull Request resolved: pytorch#120126 Approved by: https://github.com/Skylion007
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes pytorch#120020 Pull Request resolved: pytorch#120126 Approved by: https://github.com/Skylion007
@pytorchbot cherry-pick --onto release/2.2 -c critical |
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes #120020 Pull Request resolved: #120126 Approved by: https://github.com/Skylion007 (cherry picked from commit 3ad067f)
Cherry picking #120126The cherry pick PR is at #121419 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes #120020 Pull Request resolved: #120126 Approved by: https://github.com/Skylion007 (cherry picked from commit 3ad067f) Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Validated we no longer support gcc < 9 for release 2.2.2
|
It's already a requirement for building PyTorch, but should be a
requirement for linking extensions with it, as that can lead to runtime
crashes, as
std::optional
template layout is incompatible betweengcc-9 and older compilers.
Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant.
Fixes #120020
cc @jbschlosser