Optionally use hipblaslt #120551
Open
Optionally use hipblaslt #120551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120551
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8edc7b9 with merge base bab4b5a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added
the
triaged
|
@xw285cornell would appreciate your review of this. I'm assuming this PR will break your internal build? |
The hipblaslt package is not available on Fedora. Instead of requiring the package, make it optional. If it is found, define the preprocessor variable HIPBLASLT Convert the checks for ROCM_VERSION >= 507000 to HIPBLASLT checks Signed-off-by: Tom Rix <trix@redhat.com>
trixirt
force-pushed
the
optional-hipblaslt
branch
from
2c029b1
to
8edc7b9
Compare
|
Update for a couple more hipblaslt usages that were added in main this week. |
|
This PR looks pretty straight forward and using a variable instead of "magic" version numbers seem to be much cleaner. It would be nice if this PR wouldn't linger around much longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hipblaslt package is not available on Fedora.
Instead of requiring the package, make it optional. If it is found, define the preprocessor variable HIPBLASLT Convert the checks for ROCM_VERSION >= 507000 to HIPBLASLT checks
Fixes #119081