ROCm 6.0.2 #35998
Open
ROCm 6.0.2 #35998
+2,958
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Previous idea to install header to /usr/include was unfortunetely not very good. As Gentoo ships version from ROCm/half, correct place should be /usr/include/half per https://github.com/ROCm/half/blob/rocm-6.0.2/CMakeLists.txt#L27 When half.hpp is installed directly into /usr/include, it causes issues with every ROCm component, including MIOpen, MIVisionX, AMDMIGraphX, rpp, MIFin, rocAL. These projects as well as some other non-ROCm projects include <half/half.hpp>. This change is added with ebuild revbump, with few followup commits: * sci-libs/composable-kernel-5.7.1-r1 will drop dev-libs/half from dependencies (because it was never needed) * sci-libs/miopen 5.1.3 and 5.7.1 should use -DHALF_INCLUDE_DIR Other changes: * Add myself to maintainers * Change HOMEPAGE to https://github.com/ROCm/composable_kernel (because sourceforge code is not used) * Rename ROCmSoftwarePlatform -> ROCm Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…ch for 6.0.0 Other changes: * update patch for gfx1012, repeating https://salsa.debian.org/rocm-team/rocm-hipamd/-/commit/76b378eb687133267874c045396b8cb671bb50f1 * update llvm eclass to r1 * add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
* update llvm eclass to r1, allowing to specify LLVM version more precisely * add compiler-rt to RDEPEND, as hipcc automatically links to libclang_rt.builtins-x86_64.a Signed-off-by: Sv. Lockal <lockalsash@gmail.com> dev-util/hipcc: add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes comparing to 5.7.1: * rename RadeonOpenCompute -> ROCm in url * add myself to maintainers Compatibility: no issues found; seems to be bidirectionally compatible (rocm-5.7.1 libraries work with rocm-cmake-6.0.2 and in opposite). Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
This patch together with dev-util/hip and dev-libs/rocr-runtime patches allows to load code object from fat binaries based on compatibility score for given ISA instead of full match. Other changes: * Rename RadeonOpenCompute -> ROCm * Add myself to maintainers * migrate llvm eclass to r1 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…r gfx1012 This repeats change in https://salsa.debian.org/rocm-team/rocr-runtime/-/commit/da5ad99a9819f42c7c090f95bedf92529637afdc by Cordell Bloor <cgmb@slerp.xyz> Other changes: * rename RadeonOpenCompute -> ROCm * update llvm eclass to r1 * add myself to maintainers list Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…ild failure Closes: https://bugs.gentoo.org/927274 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * add llvm-18 compatibility patch (bug: ROCm/ROCm-Device-Libs#96) * remove RESTRICT variable, it was shadowed and non-functional * rename RadeonOpenCompute -> ROCm * update llvm eclass to r1 * add comment about llvm 18 compatibility issue * add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * rework soname patch to use official/Fedora soversion: librocm_smi64.so.6 (was librocm_smi64.so.1 as in Debian) * rename RadeonOpenCompute -> ROCm * add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Comparing to 5.7.1, 6.0.2 is compatible both with LLVM 17 and 18 * fix-clang-libs.patch replaced with CMAKE_PREFIX_PATH * renamed ROCm-Developer-Tools to ROCm in urls Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes since 5.7.1:
* remove-chrpath patch is not needed now
* bad percent escape fix is not needed now
* addpredict in src_configure is not needed (compilation should not access device anyways)
* removing extra copy of headers is not needed
* new patch for missing ${ROCM_PATH}/.info/version is needed now
* rename ROCmSoftwarePlatform to ROCm in urls
* fix tests directory (in 5.7.1 too)
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * fix USE=test dependency for dev-python/joblib (in 5.7.1 and 6.0.2) * ReplacementKernels-cov3 directory does not exist anymore * update expand-isa-compatibility patch to not use removed gcnArch field * update llvm eclass to r1 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * add patch for Clang 17 compatibility (official build uses Clang 18) * add patch for "Could NOT find Git (missing: GIT_EXECUTABLE)" * drop dev-libs/half dependency in all versions (not used) * rename ROCmSoftwarePlatform -> ROCm in URLs Signed-off-by: Sv. Lockal <lockalsash@gmail.com> sci-libs/composable-kernel: don't inherit from llvm Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Other changes: * Add myself as maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Dropped most of sed calls, not needed anymore * Device access is not needed to configure * Added myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Also add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes since 5.7.2: * Added patch for new issue ROCm/rocWMMA#360 * Disabled LTO due to llvm/llvm-project#61101 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Can be built with GCC; hipcc is not needed directly here * Rename ROCmSoftwarePlatform -> ROCm in URLs * Add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
* Rename ROCmSoftwarePlatform to ROCm in URLs * Add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Benchmark tools were renamed from *-rider to *-bench * Add myself to maintainers * Drop sed fixes for install path Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Can be built with gcc; hipcc is not needed directly * No patches needed * Added myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Access to device is not needed to configure and build * Add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * drop all old patches, except for enable-test * add new patch for Clang 17 compatibility (official build uses Clang 18) * new dependency on dev-util/roctracer * set >=dev-libs/half-1.12.0-r1 depencency to find half/half.hpp automatically * add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com> sci-libs/miopen: add include path for dev-libs/half Note, that it works even then half.hpp is installed into /usr/include Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * in updated expand-isa-compatibility patch do not coerce gfx1011 and gfx1012 to gfx1010, as Gentoo users can build rocBLAS for gfx1011 and gfx1012 with USE flags * add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Drop configure fixes (not needed anymore) * Add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…2-2.3.0 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…python 3.12+ Upstream bug: ROCm/rocminfo#69 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Pull Request assignmentSubmitter: @AngryLoki @gentoo/github: Too many disjoint maintainers, disabling auto-assignment. Linked bugsBugs linked: 927274 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
|
Also I would be grateful if you could merge these PRs:
so I could resolve git conflicts (if any) and apply test suite patches from there. |
Pull request CI reportReport generated at: 2024-03-30 10:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues in previous 6.0.0 ROCm packages (critical ones, which caused these packages to be masked in 563b5ab).
Major things to note:
dev-libs/halfrelocates headers from/usr/includeto/usr/include/half. However transition is smooth, as all current packages expect to seehalf.hppin/usr/include/halfin the first place.dev-util/rocm-smisoname is now librocm_smi64.so.6 (was librocm_smi64.so.1 as in Debian). Now it matches official/Fedora scheme.New packages added to gradually close gap with official release:
dev-libs/hipother- ROCclr runtime implementation for non-AMD HIP platforms, like NVIDIAsci-libs/rpp- AMD ROCm Performance Primitives (RPP) high-performance computer vision librarydev-libs/rocdbgapi- AMD Debugger API -dev-debug/gdb-14.2can debug AMDGPU code, if you build/link it with rocdbgapi.Not added:
Closes: https://bugs.gentoo.org/927274