[inductor] Refactor common triton imports into one function #121438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `@pointwise` we now generate `@triton_heuristics.pointwise` just so the imports are the same for all kernel types. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121438
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7e0dfa6 with merge base 953c6c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `pointwise` we now generate `triton_heuristics.pointwise` just so the imports are the same for all kernel types. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `pointwise` we now generate `triton_heuristics.pointwise` just so the imports are the same for all kernel types. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `pointwise` we now generate `triton_heuristics.pointwise` just so the imports are the same for all kernel types. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `pointwise` we now generate `triton_heuristics.pointwise` just so the imports are the same for all kernel types. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `pointwise` we now generate `triton_heuristics.pointwise` just so the imports are the same for all kernel types. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This was referenced Mar 8, 2024
lezcano
approved these changes
Mar 9, 2024
| @@ -91,6 +92,7 @@ def f(lhs, index, rhs): | |||
| kernel_code = kernel_list[0] | |||
| self.assertEqual(metrics._count_pattern(kernel_code, "tl.atomic_add"), 1) | |||
|
|
|||
| @largeTensorTest(25e7 * 2 * 4, device=GPU_TYPE) | |||
There was a problem hiding this comment.
Fair enough, but how come this was passing before? Or it was not, and it was just not being tested on small GPU boxes?
There was a problem hiding this comment.
It's only actually 2 GB of data, but was failing for me because of other users on the machine. Would be fine in CI.
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 9, 2024
Pull Request resolved: #121267 Approved by: https://github.com/lezcano ghstack dependencies: #121438
pianpwk
pushed a commit
that referenced
this pull request
Mar 11, 2024
This means when codegen depends on a particular import we only need to add it in one place and it's applied to all triton kernels. This also changes codegen slightly so instead of generating `@pointwise` we now generate `@triton_heuristics.pointwise` just so the imports are the same for all kernel types. Pull Request resolved: #121438 Approved by: https://github.com/lezcano
pianpwk
pushed a commit
that referenced
this pull request
Mar 11, 2024
Pull Request resolved: #121267 Approved by: https://github.com/lezcano ghstack dependencies: #121438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This means when codegen depends on a particular import we only need to
add it in one place and it's applied to all triton kernels.
This also changes codegen slightly so instead of generating
@pointwisewe now generate@triton_heuristics.pointwisejust sothe imports are the same for all kernel types.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang