Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Specify libc and libstdcxx versions in conda environments #121556

Closed
wants to merge 5 commits into from

Conversation

peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Mar 8, 2024

Without this we get mismatches between the GLIBC and GLIBCXX ABI used
by conda packages vs pytorch.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121556

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1a12269 with merge base 953c6c3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Without this we get mismatches between the GLIBC and GLIBCXX ABI used
by conda packages vs pytorch.

[ghstack-poisoned]
Without this we get mismatches between the GLIBC and GLIBCXX ABI used
by conda packages vs pytorch.

[ghstack-poisoned]
@peterbell10 peterbell10 changed the title CI: Specify sysroot_linux-64 version in conda environments CI: Specify libc and libstdcxx versions in conda environments Mar 9, 2024
# Also ensure sysroot is using a modern GLIBC to match system compilers
as_jenkins conda create -n py_$ANACONDA_PYTHON_VERSION -y\
python="$ANACONDA_PYTHON_VERSION" \
sysroot_linux-64=2.17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this script supports aarch64, this needs to change depend on uname -m

[ghstack-poisoned]
@lezcano lezcano requested review from malfet and atalman March 10, 2024 12:57
@peterbell10 peterbell10 marked this pull request as ready for review March 10, 2024 14:09
@peterbell10 peterbell10 requested a review from isuruf March 10, 2024 14:09
Comment on lines +72 to +74
# libstdcxx from conda default channels are too old, we need GLIBCXX_3.4.30
# which is provided in libstdcxx 12 and up.
conda_install libstdcxx-ng=12.3.0 -c conda-forge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with this statement, is that it adds conda-forge channel, which allows the rest of the packages to be installed from conda-forge going forward. But may be this is fine

@malfet
Copy link
Contributor

malfet commented Mar 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@peterbell10
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor

atalman commented Mar 14, 2024

@pytorchbot cherry-pick --onto release/2.3 -c regression --fixes "glibc errors"

pytorchbot pushed a commit that referenced this pull request Mar 14, 2024
Without this we get mismatches between the GLIBC and GLIBCXX ABI used
by conda packages vs pytorch.
Pull Request resolved: #121556
Approved by: https://github.com/isuruf, https://github.com/malfet

(cherry picked from commit 7a53ded)
@pytorchbot
Copy link
Collaborator

Cherry picking #121556

The cherry pick PR is at #121929 and it is linked with issue glibc errors

Details for Dev Infra team Raised by workflow job

shunting314 pushed a commit that referenced this pull request Mar 14, 2024
Without this we get mismatches between the GLIBC and GLIBCXX ABI used
by conda packages vs pytorch.
Pull Request resolved: #121556
Approved by: https://github.com/isuruf, https://github.com/malfet
atalman pushed a commit that referenced this pull request Mar 14, 2024
Without this we get mismatches between the GLIBC and GLIBCXX ABI used
by conda packages vs pytorch.
Pull Request resolved: #121556
Approved by: https://github.com/isuruf, https://github.com/malfet

(cherry picked from commit 7a53ded)

Co-authored-by: Peter Bell <peterbell10@live.co.uk>
@github-actions github-actions bot deleted the gh/peterbell10/704/head branch April 14, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants