-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify guards using info from previous guards #121463
Conversation
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121463
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b593fa8 with merge base 953c6c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
@ezyang this one's ready for review. I think that in most univariate cases the value ranges are already doing all this and more, but I think this may help when dealing with dynamic shapes. I also generalised and simplified the implementation of the "derived relations". |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Let me see what CI thinks about this one. Will add tests tomorrow.
Fixes #119917