Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify guards using info from previous guards #121463

Closed
wants to merge 9 commits into from

Conversation

lezcano
Copy link
Collaborator

@lezcano lezcano commented Mar 8, 2024

Stack from ghstack (oldest at bottom):

Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Mar 8, 2024
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 33ec4b43e55d836f535269045f24ce51adc0dafe
Pull Request resolved: #121463
Copy link

pytorch-bot bot commented Mar 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121463

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b593fa8 with merge base 953c6c3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 9523b84f5571a00aba60cbb82cabbbd8aa5be23a
Pull Request resolved: #121463
@lezcano lezcano requested a review from ezyang March 8, 2024 01:11
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 3dd9963c527f146475ae3d51780058049c91362b
Pull Request resolved: #121463
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 92210a6b678bc572919694f1951fa0d25dce39bd
Pull Request resolved: #121463
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 73653a2660ce7b10381cd8097af1a66d17bcb52a
Pull Request resolved: #121463
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 9bcaa3443e4e63224e101035a2f8c55b1e679f84
Pull Request resolved: #121463
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 301611939560e7a81ab15da7c1719a0ba7103d8c
Pull Request resolved: #121463
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: e87f8d62f7fab5f9162fd3a3c07d5ac5c6d04fd8
Pull Request resolved: #121463
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 96218368099696eb9317ee893e9d5df6b7310c15
Pull Request resolved: #121463
@lezcano
Copy link
Collaborator Author

lezcano commented Mar 8, 2024

@ezyang this one's ready for review. I think that in most univariate cases the value ranges are already doing all this and more, but I think this may help when dealing with dynamic shapes.

I also generalised and simplified the implementation of the "derived relations".

@lezcano lezcano added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 8, 2024
@ezyang
Copy link
Contributor

ezyang commented Mar 12, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: fx release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants