-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complicated guards probably are being repeatedly issued #119917
Labels
module: dynamic shapes
oncall: pt2
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Comments
@ezyang, I added "triage review" here since I guessed you might want to discuss there. Missed you though, how do you want to categorize this issue? |
@ezyang should we discuss at the next triage review? |
nah, we know what's going on, just have to do it |
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
lezcano
added a commit
that referenced
this issue
Mar 8, 2024
Let me see what CI thinks about this one. Will add tests tomorrow. Fixes #119917 [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: dynamic shapes
oncall: pt2
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
🐛 Describe the bug
@lezcano @avikchaudhuri and I were reading the symbolic shapes code and it occurred to us that if you have a complex evaluate_expr call which doesn't successfully maybe_guard_eq handled, it is possible we will add the guard every time you guard on it.
Versions
main
cc @msaroufim @bdhirsh @anijain2305 @zou3519
The text was updated successfully, but these errors were encountered: