Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complicated guards probably are being repeatedly issued #119917

Closed
ezyang opened this issue Feb 14, 2024 · 3 comments
Closed

Complicated guards probably are being repeatedly issued #119917

ezyang opened this issue Feb 14, 2024 · 3 comments
Labels
module: dynamic shapes oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@ezyang
Copy link
Contributor

ezyang commented Feb 14, 2024 •
edited by pytorch-bot bot
Loading

🐛 Describe the bug

@lezcano @avikchaudhuri and I were reading the symbolic shapes code and it occurred to us that if you have a complex evaluate_expr call which doesn't successfully maybe_guard_eq handled, it is possible we will add the guard every time you guard on it.

Versions

main

cc @msaroufim @bdhirsh @anijain2305 @zou3519
@masnesral
Copy link
Contributor

@ezyang, I added "triage review" here since I guessed you might want to discuss there. Missed you though, how do you want to categorize this issue?

@masnesral
Copy link
Contributor

@ezyang should we discuss at the next triage review?

@ezyang
Copy link
Contributor Author

ezyang commented Feb 27, 2024

nah, we know what's going on, just have to do it

@masnesral masnesral added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed triage review labels Feb 27, 2024
@lezcano lezcano mentioned this issue Mar 8, 2024
Closed
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Simplify guards using info from previous guards
771a00f 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
1a78673 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
3847f6b 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
9f93636 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
ac27e08 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Simplify guards using info from previous guards
4314b4d 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 73653a2660ce7b10381cd8097af1a66d17bcb52a
Pull Request resolved: #121463
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
a89fb3e 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
9f1a5c7 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
cfa358b 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Update on "Simplify guards using info from previous guards"
b593fa8 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

[ghstack-poisoned]
lezcano added a commit that referenced this issue Mar 8, 2024
@lezcano
Simplify guards using info from previous guards
eaa86fb 
Let me see what CI thinks about this one. Will add tests tomorrow.

Fixes #119917

ghstack-source-id: 96218368099696eb9317ee893e9d5df6b7310c15
Pull Request resolved: #121463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: dynamic shapes oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @masnesral