[dynamo] Optimize VariableTracker.__post_init__ #122034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves `benchmarks/dynamo/microbenchmarks/dynamo_microbenchmarks.py` from 8.6s to 7.3s. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122034
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 948acde with merge base 5030913 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 16, 2024
Improves `benchmarks/dynamo/microbenchmarks/dynamo_microbenchmarks.py` from 8.6s to 7.3s. [ghstack-poisoned]
Improves `benchmarks/dynamo/microbenchmarks/dynamo_microbenchmarks.py` from 8.6s to 7.3s. [ghstack-poisoned]
This was referenced Mar 17, 2024
Skylion007
reviewed
Mar 17, 2024
| @@ -30,7 +30,7 @@ class ParentsTracker: | |||
|
|
|||
| def __init__(self): | |||
| # logically this is a set, but we use a dict to ensure deterministic ordering | |||
| self.parents: Dict[ParentsTracker, bool] = dict() | |||
| self.parents: Dict[ParentsTracker, bool] = {} | |||
There was a problem hiding this comment.
I have a ruff rule for this is we want. to enable it codebase wide.
There was a problem hiding this comment.
I'd be fine with this.
Skylion007
reviewed
Mar 17, 2024
| @@ -1939,13 +1939,13 @@ def __call__(self, tx, value) -> VariableTracker: | |||
| if isinstance(value, VariableTracker): | |||
| # This is always valid to call, and useful for recursive calls. | |||
| return value | |||
| if isinstance(value, dataclasses._HAS_DEFAULT_FACTORY_CLASS): | |||
| elif isinstance(value, dataclasses._HAS_DEFAULT_FACTORY_CLASS): | |||
There was a problem hiding this comment.
Since the above statement has a return in it, I'm not sure it's actually an optimization.
There was a problem hiding this comment.
This doesn't matter, it is just a style thing.
Skylion007
approved these changes
Mar 17, 2024
Improves `benchmarks/dynamo/microbenchmarks/dynamo_microbenchmarks.py` from 8.6s to 7.3s. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
This was referenced Mar 17, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 18, 2024
Improves `benchmarks/dynamo/microbenchmarks/dynamo_microbenchmarks.py` from 7.3s to 6.7s. Pull Request resolved: #122035 Approved by: https://github.com/Skylion007 ghstack dependencies: #122032, #122033, #122034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Improves
benchmarks/dynamo/microbenchmarks/dynamo_microbenchmarks.pyfrom 8.6s to 7.3s.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang