Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

necessary change to make torch2.3 work with triton2.2 #122139

Merged
merged 1 commit into from Mar 21, 2024

Conversation

shunting314
Copy link
Contributor

@shunting314 shunting314 commented Mar 18, 2024

This PR contains necessary changes on PyTorch side to make torch2.3 work with triton2.2. Mainly 2 changes

  1. make remote autotune cache work
  2. make user defined triton kernel work to parse triton ir.

Copy link

pytorch-bot bot commented Mar 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122139

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit a0c093f with merge base 86a2d67 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shunting314
Copy link
Contributor Author

If we see some errors on this PR regarding triton API change. That should be expected since this PR is still running against a different version of triton rather than triton 2.2.x. Full tests is done in #121781

@atalman atalman merged commit c4e5434 into release/2.3 Mar 21, 2024
93 of 98 checks passed
guangy10 added a commit that referenced this pull request Mar 26, 2024
@github-actions github-actions bot deleted the make-torch2.3-work-with-triton2.2 branch April 21, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants