New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update triton pin for release 2.3 #121781
base: release/2.3
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121781
Note: Links to docs will display an error until the docs builds have been completed. ❌ 21 New Failures, 7 Unrelated FailuresAs of commit d0933e6 with merge base 86a2d67 (): NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5e36c05
to
b81ea2a
Compare
1747abd
to
87b3a3a
Compare
cc @atalman for the error regarding building triton wheels |
We also see a bunch of GLIBCXX related failures. I'm worried that they may hide other triton related issues. @atalman |
GLIBCXX error is fixed by #121556 |
…release (#115379) (#121901) Cherry pick of #115379 from Release 2.2 that should be applied to main and Release 2.3 as well Pull Request resolved: #121901 Approved by: https://github.com/DanilBaibak, https://github.com/jeanschmidt
Without this we get mismatches between the GLIBC and GLIBCXX ABI used by conda packages vs pytorch. Pull Request resolved: #121556 Approved by: https://github.com/isuruf, https://github.com/malfet
87b3a3a
to
e34c79e
Compare
2f83d1c
to
748343a
Compare
748343a
to
d0933e6
Compare
CI is finally clean! The only failures not related to building a wheel also happens on the base commit. Will check how perf looks |
I've create a separate PR to only include the necessary PyTorch side change to make it work with the triton release (#122139). Keep this PR around since all the tests are done in this PR |
The current status of the PR:
I'll now clean up the PR to only keep the necessary PyTorch side change to make it work with tirton 2.2.x . Other hacks coming up to do the tests will be removed (e.g. pointing to my triton fork).
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang