Upgrade submodule pybind to 2.12.0 #122899
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122899
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 5960c56 with merge base abe4a0e ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The test suite is pretty comprehensive, so no need to run anything else I'd say. Also, the |
|
@rgommers Can confirm internal tests covered PyTorch through Google's import suite. |
|
@pytorchbot merge -i |
|
This PR updates submodules third_party/pybind11 If those updates are intentional, please add "submodule" keyword to PR title/description. |
Skylion007
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-focal-rocm6.0-py3.8 / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.3 -c critical |
To fix #122056 Building with NP 2.0 allows me to run locally with both NP 2.0 and 1.26. Any other test we should run @rgommers ? FYI @Skylion007 @atalman Pull Request resolved: #122899 Approved by: https://github.com/Skylion007 (cherry picked from commit 6c2f36c)
Cherry picking #122899The cherry pick PR is at #123355 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
To fix #122056 Building with NP 2.0 allows me to run locally with both NP 2.0 and 1.26. Any other test we should run @rgommers ? FYI @Skylion007 @atalman Pull Request resolved: #122899 Approved by: https://github.com/Skylion007 (cherry picked from commit 6c2f36c) Co-authored-by: albanD <desmaison.alban@gmail.com>
To fix pytorch#122056 Building with NP 2.0 allows me to run locally with both NP 2.0 and 1.26. Any other test we should run @rgommers ? FYI @Skylion007 @atalman Pull Request resolved: pytorch#122899 Approved by: https://github.com/Skylion007
To fix #122056
Building with NP 2.0 allows me to run locally with both NP 2.0 and 1.26.
Any other test we should run @rgommers ?
FYI @Skylion007 @atalman