Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin protobuf to 3.20.2 on macOS #123197

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Pin protobuf to 3.20.2 on macOS #123197

merged 1 commit into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. Pin protobuf to 3.20.2 on macOS (#121918) 

    The newer protobuf 5.26.0 releasing on March 13rd is causing failures with `test_hparams_*` from `test_tensorboard` in which the stringify metadata is wrong when escaping double quote. For example, https://hud.pytorch.org/pytorch/pytorch/commit/3bc2bb678150e02bfa2552b82572d771a892d0c3.  This looks like an upstream issue from Tensorboard where it doesn't work with this brand new protobuf version https://github.com/tensorflow/tensorboard/blob/master/tensorboard/pip_package/requirements.txt#L29

The package has been pinned on Docker https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L155, so it should be pinned on macOS too.  We want to eventually just have one requirements.txt file.

Fixes #122008
Fixes #121927
Fixes #121946
Pull Request resolved: #121918
Approved by: https://github.com/kit1980
    @huydhn
    huydhn committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e22e17e View commit details
    Browse the repository at this point in the history