Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numpy 2.0.0rc1 in CI #123286

Closed
wants to merge 1 commit into from
Closed

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Apr 3, 2024

Bump numpy version to 2.0.0rc1 in CI

Related to: #107302

@atalman atalman requested a review from a team as a code owner April 3, 2024 20:35
Copy link

pytorch-bot bot commented Apr 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123286

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2c208a9 with merge base 9e0838f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman
Copy link
Contributor Author

atalman commented Apr 4, 2024

@pytorchmergebot merge -f "All signals are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Apr 4, 2024

Do you mind enabling it for Windows as well? (as it will only work for Linux and Mac now, isn't it?)

@atalman
Copy link
Contributor Author

atalman commented Apr 4, 2024

@pytorchbot cherry-pick --onto release/2.3 -c critical

pytorchbot pushed a commit that referenced this pull request Apr 4, 2024
Bump numpy version to 2.0.0rc1 in CI

Related to: #107302
Pull Request resolved: #123286
Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi

(cherry picked from commit 26b4ccf)
@pytorchbot
Copy link
Collaborator

Cherry picking #123286

The cherry pick PR is at #123356 and it is recommended to link a critical cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

pytorchmergebot pushed a commit that referenced this pull request Apr 4, 2024
Bump numpy version to 2.0.0rc1 in CI

Related to: #107302
Pull Request resolved: #123286
Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi

(cherry picked from commit 26b4ccf)
@atalman
Copy link
Contributor Author

atalman commented Apr 4, 2024

@malfet looks like all our windows CI tests are on py3.8 we would need to move them to py3.9 and then enable numpy 2.0.0 testing

@malfet
Copy link
Contributor

malfet commented Apr 4, 2024

@atalman Why not move them all the way to 3.12?

atalman added a commit that referenced this pull request Apr 4, 2024
Bump numpy version to 2.0.0rc1 in CI

Related to: #107302
Pull Request resolved: #123286
Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi

(cherry picked from commit 26b4ccf)

Co-authored-by: atalman <atalman@fb.com>
sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants