New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use numpy 2.0.0rc1 in CI #123286
Use numpy 2.0.0rc1 in CI #123286
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123286
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2c208a9 with merge base 9e0838f (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchmergebot merge -f "All signals are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Do you mind enabling it for Windows as well? (as it will only work for Linux and Mac now, isn't it?) |
@pytorchbot cherry-pick --onto release/2.3 -c critical |
Bump numpy version to 2.0.0rc1 in CI Related to: #107302 Pull Request resolved: #123286 Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi (cherry picked from commit 26b4ccf)
Cherry picking #123286The cherry pick PR is at #123356 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
Bump numpy version to 2.0.0rc1 in CI Related to: #107302 Pull Request resolved: #123286 Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi (cherry picked from commit 26b4ccf)
@malfet looks like all our windows CI tests are on py3.8 we would need to move them to py3.9 and then enable numpy 2.0.0 testing |
@atalman Why not move them all the way to 3.12? |
Bump numpy version to 2.0.0rc1 in CI Related to: #107302 Pull Request resolved: #123286 Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi (cherry picked from commit 26b4ccf) Co-authored-by: atalman <atalman@fb.com>
Bump numpy version to 2.0.0rc1 in CI Related to: pytorch#107302 Pull Request resolved: pytorch#123286 Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/ZainRizvi
Bump numpy version to 2.0.0rc1 in CI
Related to: #107302