Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE]: Update cudnn to 9.1.0.70 #123475

Closed
wants to merge 28 commits into from
Closed

[BE]: Update cudnn to 9.1.0.70 #123475

wants to merge 28 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Apr 5, 2024

@eqy eqy added module: cudnn Related to torch.backends.cudnn, and CuDNN support open source topic: not user facing topic category labels Apr 5, 2024
@eqy eqy requested review from Skylion007 and malfet April 5, 2024 21:31
@eqy eqy requested review from a team and jeffdaily as code owners April 5, 2024 21:31
Copy link

pytorch-bot bot commented Apr 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123475

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures, 7 Unrelated Failures

As of commit 8d85d49 with merge base 0de6d24 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming you fix the Caffe2 issue.

@eqy
Copy link
Collaborator Author

eqy commented Apr 8, 2024

@Skylion007 do we anticipate #122527 landing in the near-future? caffe2 fixes might be involved and look something like #115719 which might be unnecessary if caffe2 is being removed soon

@r-barnes
Copy link
Contributor

@eqy - I'm still working on eliminating caffe2, but having difficulty isolating all the issues - I haven't worked deeply with PyTorch's build before.

@eqy eqy changed the title [BE]: Update cudnn to 9.0.0.312 [BE]: Update cudnn to 9.1.0.70 May 2, 2024
@johnnynunez
Copy link

9.1.1 is out

@eqy
Copy link
Collaborator Author

eqy commented May 10, 2024

@pytorchmergebot rebase (checking to see if caffe2 issue has been resolved)

Copy link

pytorch-bot bot commented May 10, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: (checking to see if caffe2 issue has been resolved)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@eqy
Copy link
Collaborator Author

eqy commented May 10, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased updatecudnn9 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout updatecudnn9 && git pull --rebase)

@Skylion007
Copy link
Collaborator

@eqy Looks like the issues were fixed. Let's merge.

@eqy
Copy link
Collaborator Author

eqy commented May 13, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eqy
Copy link
Collaborator Author

eqy commented May 13, 2024

@pytorchmergebot rebase

@atalman
Copy link
Contributor

atalman commented Jun 6, 2024

@pytorchmergebot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
cuDNN has managed to upload cu11 and cu12 wheels for ~~9.0.0.312~~ 9.1.0.70, so trying this out...

CC @Skylion007 @malfet

Co-authored-by: Wei Wang <weiwan@nvidia.com>
Co-authored-by: atalman <atalman@fb.com>
Pull Request resolved: pytorch#123475
Approved by: https://github.com/Skylion007, https://github.com/malfet, https://github.com/nWEIdia, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: cudnn Related to torch.backends.cudnn, and CuDNN support module: dynamo module: inductor open source Reverted topic: new features topic category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet