-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expunge torch.utils.trainer.* #12487
Conversation
Maybe keep the |
Assuming this was discussed beforehand, I'm happy to land this. |
This has been in our codebase since forever and we've always been telling people not to use it. Let's just get rid of it once and for all. It's not even documented. |
travis actually passed. i'm landing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SsnL is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Differential Revision: D10273602 Pulled By: SsnL fbshipit-source-id: 630c1f8ee0e366f7092d4f93dbe1efa96fc860e0
Differential Revision: D10273602 Pulled By: SsnL fbshipit-source-id: 630c1f8ee0e366f7092d4f93dbe1efa96fc860e0
Differential Revision: D10273602 Pulled By: SsnL fbshipit-source-id: 630c1f8ee0e366f7092d4f93dbe1efa96fc860e0
cc: @apaszke