Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to remove unused variable #125252

Closed
wants to merge 1 commit into from
Closed

Refactoring to remove unused variable #125252

wants to merge 1 commit into from

Conversation

jainapurva
Copy link
Contributor

Summary: Removed unused variable for running encoder

Test Plan: buck test //caffe2/test:transformers

Differential Revision: D56771972

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 30, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125252

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d7511f4 with merge base 90258e8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 30, 2024
@jainapurva @facebook-github-bot
Refactoring to remove unused variable
d7511f4 
Summary: Removed unused variable for running encoder

Test Plan: buck test //caffe2/test:transformers

Differential Revision: D56771972
@jainapurva jainapurva requested a review from drisspg April 30, 2024 20:20
drisspg
drisspg approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replicating internal stamp

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 30, 2024
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@jainapurva @andoorve
Refactoring to remove unused variable (pytorch#125252)
cee1ebc 
Summary: Removed unused variable for running encoder

Test Plan: buck test //caffe2/test:transformers

Differential Revision: D56771972

Pull Request resolved: pytorch#125252
Approved by: https://github.com/drisspg
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56771972

@drisspg
Copy link
Contributor

drisspg commented May 2, 2024

@pytorchbot revert "going to land codev"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message, -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@drisspg
Copy link
Contributor

drisspg commented May 2, 2024

@pytorchbot revert -m "going to land codev"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@drisspg
Copy link
Contributor

drisspg commented May 2, 2024

@pytorchbot revert -m "going to land codev" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@jainapurva your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request May 2, 2024
@pytorchmergebot
Revert "Refactoring to remove unused variable (#125252)"
a930950 
This reverts commit b094622.

Reverted #125252 on behalf of https://github.com/drisspg due to going to land codev ([comment](#125252 (comment)))
@izaitsevfb izaitsevfb mentioned this pull request May 2, 2024
Closed
@pytorch pytorch deleted a comment from pytorch-bot bot May 2, 2024
@izaitsevfb
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

force-merging to unbreak #125402

@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #125252

petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@jainapurva @petrex
Refactoring to remove unused variable (pytorch#125252)
a87321e 
Summary: Removed unused variable for running encoder

Test Plan: buck test //caffe2/test:transformers

Differential Revision: D56771972

Pull Request resolved: pytorch#125252
Approved by: https://github.com/drisspg
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@pytorchmergebot @petrex
Revert "Refactoring to remove unused variable (#125252)"
1a4d9b3 
This reverts commit b094622.

Reverted #125252 on behalf of https://github.com/drisspg due to going to land codev ([comment](#125252 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jainapurva @Skylion007 @pytorchmergebot @facebook-github-bot @drisspg @izaitsevfb