Memoize local_scalar_dense calls, refactor all memos

[ezyang]

Stack from ghstack (oldest at bottom):

• -> Memoize local_scalar_dense calls, refactor all memos #125623

Signed-off-by: Edward Z. Yang ezyang@meta.com

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125623

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 730446c with merge base b6bcd09 ():

NEW FAILURE - The following job has failed:

• inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
  test_modules.py::TestModuleCUDA::test_memory_format_nn_BatchNorm2d_eval_mode_cuda_float64

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• trunk / linux-focal-rocm6.1-py3.8 / test (default, 1, 1, linux.rocm.gpu) (gh) (similar failure)
  test_cuda.py::TestCudaMallocAsync::test_clock_speed

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[eellison]

Worth generalizing this ? @IvanKobzarev was also recently asking for .tolist() memoization

[ezyang]

alright

[ezyang]

@eellison here, have a descriptor

[ezyang]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/ezyang/2730/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/export/test_export.py
CONFLICT (content): Merge conflict in test/export/test_export.py
Auto-merging torch/_subclasses/fake_tensor.py
error: could not apply f28a82e78bd... Memoize local_scalar_dense calls
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply f28a82e78bd... Memoize local_scalar_dense calls

Raised by https://github.com/pytorch/pytorch/actions/runs/8996177476

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[ezyang]

@pytorchbot merge -f "spurious rocm failures"

[pytorchmergebot]

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[malfet]

@pytorchbot merge -m "Broke ROCM, see https://github.com/pytorch/pytorch/actions/runs/9026074378/job/24804583041" -c ignore signal

[pytorch-bot]

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -m Broke ROCM, see https://github.com/pytorch/pytorch/actions/runs/9026074378/job/24804583041 -c ignore signal

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

[malfet]

@pytorchbot revert -m "Broke ROCM and CUDA inductor tests, see https://github.com/pytorch/pytorch/actions/runs/9026074378/job/24804583041" -c ignore signal

[pytorch-bot]

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: argument -c/--classification: invalid choice: 'ignore' (choose from 'nosignal', 'ignoredsignal', 'landrace', 'weird', 'ghfirst')

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

[malfet]

Or may be it was done by #125829

[malfet]

@pytorchbot revert -m "Broke ROCM, see https://github.com/pytorch/pytorch/actions/runs/9026074378/job/24804583041" -c ignoredsignal

[pytorchmergebot]

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

[pytorchmergebot]

@ezyang your PR has been successfully reverted.

[ezyang]

There's no way this possible could have caused the ROCm problems. I'm guessing they are having some server problem

[ezyang]

@pytorchbot merge -f "confirmed from hud that reverting this didn't fix anything"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here