Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow symbols to reach conv_layout stride argument #125829

Closed
wants to merge 2 commits into from
Closed

Allow symbols to reach conv_layout stride argument #125829

wants to merge 2 commits into from

Conversation

laithsakka
Copy link
Contributor

@laithsakka laithsakka commented May 9, 2024 •
edited

@laithsakka
Update
f0c0b1e 
[ghstack-poisoned]
@laithsakka laithsakka mentioned this pull request May 9, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125829

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cb3ccc with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka added a commit that referenced this pull request May 9, 2024
@laithsakka
Fix conv_layout
f476240 
ghstack-source-id: bbf7a446baa8223555d77eb4a8f2de1c8826c083
Pull Request resolved: #125829
@laithsakka laithsakka changed the title Fix conv_layout Allow symbols to reach conv_layout stride argument May 9, 2024
@laithsakka
Update
8cb3ccc 
[ghstack-poisoned]
laithsakka added a commit that referenced this pull request May 9, 2024
@laithsakka
Fix conv_layout
36c1f2b 
ghstack-source-id: b183e0ab8f6cea5f28dbfc24981d4de2854dbc87
Pull Request resolved: #125829
@laithsakka
Copy link
Contributor Author

rebase on main to check if failures are for sire related to my change

@laithsakka laithsakka added the topic: not user facing topic category label May 10, 2024
@laithsakka
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request May 11, 2024
Closed
@malfet
Copy link
Contributor

malfet commented May 11, 2024

@pytorchbot revert -m "Broke inductor tests, see https://github.com/pytorch/pytorch/actions/runs/9028121462/job/24809113861" -c landrace

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request May 11, 2024
@pytorchmergebot
Revert "Allow symbols to reach conv_layout stride argument (#125829)"
7e92a2c 
This reverts commit 013722b.

Reverted #125829 on behalf of https://github.com/malfet due to Broke inductor tests, see https://github.com/pytorch/pytorch/actions/runs/9028121462/job/24809113861 ([comment](#125829 (comment)))
@pytorchmergebot
Copy link
Collaborator

@laithsakka your PR has been successfully reverted.

@laithsakka laithsakka mentioned this pull request May 13, 2024
Closed
@laithsakka
Copy link
Contributor Author

#126116 override this,

@laithsakka laithsakka closed this May 13, 2024
tinglvv pushed a commit to tinglvv/pytorch that referenced this pull request May 14, 2024
@pytorchmergebot @tinglvv
Revert "Allow symbols to reach conv_layout stride argument (pytorch#1…
1887eae 
…25829)"

This reverts commit 013722b.

Reverted pytorch#125829 on behalf of https://github.com/malfet due to Broke inductor tests, see https://github.com/pytorch/pytorch/actions/runs/9028121462/job/24809113861 ([comment](pytorch#125829 (comment)))
pytorchmergebot pushed a commit that referenced this pull request May 14, 2024
@laithsakka @pytorchmergebot
Allow symbols to reach conv_layout stride argument #125829 (#126116)
023f05c 
#125829 was reverted i rebased and the error could be merge error
because its not reproducible.

Pull Request resolved: #126116
Approved by: https://github.com/anijain2305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laithsakka @pytorchmergebot @malfet @anijain2305