Beef up error message for pending assert failure #126212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126212
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 96d6fea with merge base ee8c155 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
May 14, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 64358827bda149829ca50600c6ac93a3963d6727 Pull Request resolved: #126212
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
miladm and
SherlockNoMad
|
The gdoc is a stub but I'll add more to it soon |
ezyang
added a commit
that referenced
this pull request
May 14, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 2baed267869f8c471616cb73a4f69d551e39feac Pull Request resolved: #126212
ezyang
added
ciflow/trunk
ezyang
added a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 7625fe586320d0b6d322985e80208ba4b895194a Pull Request resolved: #126212
Skylion007
approved these changes
May 15, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
smalltalkman
pushed a commit
to smalltalkman/pytorch
that referenced
this pull request
May 15, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#126212 Approved by: https://github.com/Skylion007
albanD
requested changes
May 15, 2024
| @@ -2796,6 +2796,7 @@ | |||
| "ConstraintViolationError", | |||
| "DynamicDimConstraintPrinter", | |||
| "GuardOnDataDependentSymNode", | |||
| "PendingUnbackedSymbolNotFound", | |||
There was a problem hiding this comment.
Adding new entries in this file is NOT ok. We should document all the new public API we add!
pytorchmergebot
pushed a commit
that referenced
this pull request
May 15, 2024
Skip the newly added bad API from #126212 to keep CI green. Pull Request resolved: #126321 Approved by: https://github.com/ezyang
|
This was merged into trunk (label is properly updated). |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#126212 Approved by: https://github.com/Skylion007
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Skip the newly added bad API from pytorch#126212 to keep CI green. Pull Request resolved: pytorch#126321 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com