Fix lint failures coming from #126035 #126378
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126378
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6368112 with merge base cdcba4d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge -f 'Already rebase to main, lint jobs are green, trying to see if this helps' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Trying to add yet another lint fix from https://hud.pytorch.org/pr/pytorch/pytorch/126357 and will reland this' -c weird |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 5fa1f4c. Reverted #126378 on behalf of https://github.com/huydhn due to Trying to add yet another lint fix from https://hud.pytorch.org/pr/pytorch/pytorch/126357 and will reland this ([comment](#126378 (comment)))
|
@huydhn your PR has been successfully reverted. |
pytorch-bot
bot
added
module: distributed_checkpoint
oncall: distributed
|
@pytorchbot merge -f 'Another attempt' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
MYPY somehow shows lots of local failures for me. The issue is tracked in pytorch#126361. This is only to keep trunk sane. These two line were added by pytorch#126035 as an attempt to fix lint there, but didn't seem to help. Pull Request resolved: pytorch#126378 Approved by: https://github.com/kit1980
This reverts commit 5fa1f4c. Reverted pytorch#126378 on behalf of https://github.com/huydhn due to Trying to add yet another lint fix from https://hud.pytorch.org/pr/pytorch/pytorch/126357 and will reland this ([comment](pytorch#126378 (comment)))
MYPY somehow shows lots of local failures for me. The issue is tracked in pytorch#126361. This is only to keep trunk sane. These two line were added by pytorch#126035 as an attempt to fix lint there, but didn't seem to help. Pull Request resolved: pytorch#126378 Approved by: https://github.com/kit1980
MYPY somehow shows lots of local failures for me. The issue is tracked in #126361. This is only to keep trunk sane. These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @LucasLLC