Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Caffe2 python code #126035

Closed
wants to merge 3 commits into from
Closed

Remove Caffe2 python code #126035

wants to merge 3 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 12, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126035

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 002ba36 with merge base ef7d8ad (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added caffe2 ciflow/linux-aarch64 linux aarch64 CI workflow module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration labels May 12, 2024
@cyyever cyyever added topic: deprecation topic category topic: bc breaking topic category ciflow/trunk Trigger trunk jobs on your pull request labels May 12, 2024
@cyyever cyyever requested a review from ezyang May 12, 2024 23:39
@cyyever cyyever added ciflow/binaries Trigger all binary build and upload jobs on the PR skip-pr-sanity-checks labels May 12, 2024
@cyyever cyyever requested a review from Skylion007 May 12, 2024 23:41
@cyyever cyyever added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label May 13, 2024
@cyyever cyyever requested a review from r-barnes May 13, 2024 14:35
@cyyever
Copy link
Collaborator Author

cyyever commented May 14, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased caffe2_python_code onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout caffe2_python_code && git pull --rebase)

r-barnes
r-barnes approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@r-barnes r-barnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

@cyyever cyyever requested a review from malfet May 14, 2024 08:29
@r-barnes
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented May 14, 2024 •
edited
Loading

@jeanschmidt @r-barnes The lint error is unrelated as it happened before. I think the reason is that onnx is not installed in linter CI, and this PR triggers the lint check.

@cyyever cyyever requested a review from a team as a code owner May 14, 2024 23:10
@cyyever
Copy link
Collaborator Author

cyyever commented May 15, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 6 jobs have failed, first few of them are: windows-binary-conda / conda-py3_12-cuda12_1-test, windows-binary-conda / conda-py3_8-cuda11_8-test, windows-binary-conda / conda-py3_8-cuda11_8-upload, windows-binary-conda / conda-py3_12-cuda12_1-upload, windows-binary-wheel / wheel-py3_9-cuda12_4-test

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented May 15, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 6 checks: windows-binary-conda / conda-py3_12-cuda12_1-test, windows-binary-conda / conda-py3_8-cuda11_8-test, windows-binary-conda / conda-py3_8-cuda11_8-upload, windows-binary-conda / conda-py3_12-cuda12_1-upload, windows-binary-wheel / wheel-py3_9-cuda12_4-test, windows-binary-wheel / wheel-py3_9-cuda12_4-upload

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

huydhn added a commit to huydhn/pytorch that referenced this pull request May 16, 2024
@huydhn
Fix lint failures coming from pytorch#126035
7c82db6
@huydhn huydhn mentioned this pull request May 16, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request May 16, 2024
@huydhn @pytorchmergebot
Fix lint failures coming from #126035 (#126378)
5fa1f4c 
MYPY somehow shows lots of local failures for me.  The issue is tracked in #126361.  This is only to keep trunk sane.  These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.
Pull Request resolved: #126378
Approved by: https://github.com/kit1980
pytorchmergebot added a commit that referenced this pull request May 16, 2024
@pytorchmergebot
Revert "Fix lint failures coming from #126035 (#126378)"
cdcba4d 
This reverts commit 5fa1f4c.

Reverted #126378 on behalf of https://github.com/huydhn due to Trying to add yet another lint fix from https://hud.pytorch.org/pr/pytorch/pytorch/126357 and will reland this ([comment](#126378 (comment)))
pytorchmergebot pushed a commit that referenced this pull request May 16, 2024
@huydhn @pytorchmergebot
Fix lint failures coming from #126035 (#126378)
d61a81a 
MYPY somehow shows lots of local failures for me.  The issue is tracked in #126361.  This is only to keep trunk sane.  These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.

Pull Request resolved: #126378
Approved by: https://github.com/kit1980
@cyyever cyyever deleted the caffe2_python_code branch May 18, 2024 02:46
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@cyyever @ZelboK
Remove Caffe2 python code (pytorch#126035)
eb5e9ed 
Follows the recent changes of Caffe2.

Pull Request resolved: pytorch#126035
Approved by: https://github.com/r-barnes, https://github.com/Skylion007
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@huydhn @ZelboK
Fix lint failures coming from pytorch#126035 (pytorch#126378)
7dab5f7 
MYPY somehow shows lots of local failures for me.  The issue is tracked in pytorch#126361.  This is only to keep trunk sane.  These two line were added by pytorch#126035 as an attempt to fix lint there, but didn't seem to help.
Pull Request resolved: pytorch#126378
Approved by: https://github.com/kit1980
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@pytorchmergebot @ZelboK
Revert "Fix lint failures coming from pytorch#126035 (pytorch#126378)"
75289f2 
This reverts commit 5fa1f4c.

Reverted pytorch#126378 on behalf of https://github.com/huydhn due to Trying to add yet another lint fix from https://hud.pytorch.org/pr/pytorch/pytorch/126357 and will reland this ([comment](pytorch#126378 (comment)))
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@huydhn @ZelboK
Fix lint failures coming from pytorch#126035 (pytorch#126378)
adc0551 
MYPY somehow shows lots of local failures for me.  The issue is tracked in pytorch#126361.  This is only to keep trunk sane.  These two line were added by pytorch#126035 as an attempt to fix lint there, but didn't seem to help.

Pull Request resolved: pytorch#126378
Approved by: https://github.com/kit1980
@kit1980 kit1980 removed the Reverted label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@r-barnes r-barnes r-barnes approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
caffe2 ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source release notes: build release notes category skip-pr-sanity-checks suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category topic: build topic: deprecation topic category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cyyever @pytorchmergebot @r-barnes @jeanschmidt @Skylion007 @kit1980 @pytorchbot