Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor variables / function names related to non-strict export #126458

Closed
wants to merge 3 commits into from
Closed

Refactor variables / function names related to non-strict export #126458

wants to merge 3 commits into from

Conversation

jiashenC
Copy link
Contributor

Improve variable and function naming for better clarity: non strict --> aten.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126458

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 45a84de with merge base bed1c60 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jiashenC jiashenC requested a review from angelayi May 16, 2024 21:27
@jiashenC jiashenC changed the title Refactor variables / function names related to non-strict Refactor variables / function names related to non-strict export May 16, 2024
@jiashenC jiashenC marked this pull request as ready for review May 16, 2024 21:28
angelayi
angelayi reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@angelayi angelayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these refactor diffs, please remember to import the PR to fbsource, and land from internal

torch/export/_trace.py Outdated Show resolved Hide resolved
torch/export/_trace.py Outdated Show resolved Hide resolved
@jiashenC jiashenC requested a review from angelayi May 16, 2024 21:48
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@jiashenC @ZelboK
Refactor variables / function names related to non-strict export (pyt…
d82bbb0 
…orch#126458)

Improve variable and function naming for better clarity: `non strict` --> `aten`.
Pull Request resolved: pytorch#126458
Approved by: https://github.com/angelayi
@github-actions github-actions bot deleted the refactor_export_rename branch June 18, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiashenC @facebook-github-bot @pytorchmergebot @angelayi