Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE][Ez]: Use NotADirectoryError in tensorboard writer #126534

Conversation

Skylion007
Copy link
Collaborator

Slightly improve exception typing for tensorboard wrriter

@Skylion007 Skylion007 added better-engineering Relatively self-contained tasks for better engineering contributors release notes: python_frontend release notes category labels May 17, 2024
Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126534

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 17ef645 with merge base 4ed93d6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 changed the title [BE]: Use NotADirectoryError in tensorboard writer [BE][Ez]: Use NotADirectoryError in tensorboard writer May 17, 2024
@ezyang
Copy link
Contributor

ezyang commented May 17, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
Slightly improve exception typing for tensorboard wrriter
Pull Request resolved: pytorch#126534
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants