Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite existing links to custom ops gdocs with the landing page #127423

Closed
wants to merge 3 commits into from

Conversation

NB: these links will be live after the docs build happens, which is once
a day.

Test Plan:
- existing tests

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127423

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit a8f54fd with merge base 0ff2f8b (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…g page"

NB: these links will be live after the docs build happens, which is once
a day.

Test Plan:
- existing tests

[ghstack-poisoned]
…g page"

NB: these links will be live after the docs build happens, which is once
a day.

Test Plan:
- existing tests

[ghstack-poisoned]
@zou3519 zou3519 added ciflow/trunk Trigger trunk jobs on your pull request labels May 29, 2024
@zou3519 zou3519 added the release notes: composability release notes category label May 29, 2024
pytorchmergebot pushed a commit that referenced this pull request May 30, 2024
…#127301)

Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded
functions). The usual way to handle this is to turn those extensions
into custom ops. This PR adds a nicer graph break message and also
changes it to unconditionally warn on this graph break (because graph
break messages are usually not visible).

Fixes #126799

Test Plan:
- new test

Pull Request resolved: #127301
Approved by: https://github.com/jansel
ghstack dependencies: #127291, #127292, #127400, #127423
@github-actions github-actions bot deleted the gh/zou3519/998/head branch June 30, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: composability release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants