opcheck should be usable without optional dependencies #127292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127292
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fface8a with merge base 0ff2f8b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
May 28, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests ghstack-source-id: 02fe50fceb83ea3d29b6595b4ceda187b78892ac Pull Request resolved: #127292
zou3519
requested review from
albanD and
williamwen42
and removed request for
a team and
mruberry
zou3519
added a commit
that referenced
this pull request
May 28, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests ghstack-source-id: 944831a31155ae4f6c0b0c666914a75c17de42af Pull Request resolved: #127292
williamwen42
approved these changes
May 28, 2024
zou3519
added
ciflow/trunk
|
@pytorchbot merge -f "labels check is erroneous?" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced May 29, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
May 30, 2024
We create a new landing page for PyTorch custom ops (suggested by jansel). All of our error messages will link here, and I'll work with the docs team to see if we can boost SEO for this page. NB: the landing page links some non-searchable webpages. Two of those (the Python custom ops tutorial and C++ custom ops tutorial) will turn into actual webpages when PyTorch 2.4 comes around. I'll make the third one (the Custom Operators Manual) once it stabilizes (we continously add new things to it and the length means that we might want to create a custom website for it to make the presentation more ingestable). Test Plan: - view docs preview. Pull Request resolved: #127400 Approved by: https://github.com/jansel ghstack dependencies: #127291, #127292
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 30, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests Pull Request resolved: #127292 Approved by: https://github.com/williamwen42 ghstack dependencies: #127291
Aidyn-A
pushed a commit
to tinglvv/pytorch
that referenced
this pull request
May 30, 2024
We create a new landing page for PyTorch custom ops (suggested by jansel). All of our error messages will link here, and I'll work with the docs team to see if we can boost SEO for this page. NB: the landing page links some non-searchable webpages. Two of those (the Python custom ops tutorial and C++ custom ops tutorial) will turn into actual webpages when PyTorch 2.4 comes around. I'll make the third one (the Custom Operators Manual) once it stabilizes (we continously add new things to it and the length means that we might want to create a custom website for it to make the presentation more ingestable). Test Plan: - view docs preview. Pull Request resolved: pytorch#127400 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127291, pytorch#127292
pytorchmergebot
pushed a commit
that referenced
this pull request
May 30, 2024
…7423) NB: these links will be live after the docs build happens, which is once a day. Test Plan: - existing tests Pull Request resolved: #127423 Approved by: https://github.com/jansel, https://github.com/williamwen42 ghstack dependencies: #127291, #127292, #127400
pytorchmergebot
pushed a commit
that referenced
this pull request
May 30, 2024
…#127301) Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test Pull Request resolved: #127301 Approved by: https://github.com/jansel ghstack dependencies: #127291, #127292, #127400, #127423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR excises opcheck's dependency on
torch.testing._internal.common_utils, (which comes with dependencies on
expecttest and hypothesis). We do this by moving what we need to
torch.testing._utils and adding a test for it.
Fixes #126870, #126871
Test Plan: