Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip default value for mypy disallow_untyped_defs [5/11] #127842

Closed
wants to merge 3 commits into from
Closed

Flip default value for mypy disallow_untyped_defs [5/11] #127842

wants to merge 3 commits into from

Conversation

aorenste
Copy link
Contributor

@aorenste aorenste commented Jun 4, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127842

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit 33b84df with merge base 62bcdc0 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Jun 4, 2024
This was referenced Jun 4, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@aorenste aorenste changed the title Flip default value for mypy disallow_untyped_defs [5/11]\nSee #127836 for details. Flip default value for mypy disallow_untyped_defs [5/11] Jun 4, 2024
@aorenste aorenste marked this pull request as ready for review June 4, 2024 20:20
@aorenste aorenste added the topic: not user facing topic category label Jun 5, 2024
@aorenste
Update on "Flip default value for mypy disallow_untyped_defs [5/11]"
673b2cc 
See #127836 for details.




cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k LucasLLC

[ghstack-poisoned]
@aorenste
Update on "Flip default value for mypy disallow_untyped_defs [5/11]"
33b84df 
See #127836 for details.




cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k LucasLLC

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jun 8, 2024
@aorenste @pytorchmergebot
Flip default value for mypy disallow_untyped_defs [6/11] (#127843)
7c12cc7 
See #127836 for details.

Pull Request resolved: #127843
Approved by: https://github.com/oulgen
ghstack dependencies: #127842
pytorchmergebot pushed a commit that referenced this pull request Jun 8, 2024
@aorenste @pytorchmergebot
Flip default value for mypy disallow_untyped_defs [7/11] (#127844)
038b927 
See #127836 for details.

Pull Request resolved: #127844
Approved by: https://github.com/oulgen
ghstack dependencies: #127842, #127843
pytorchmergebot pushed a commit that referenced this pull request Jun 8, 2024
@aorenste @pytorchmergebot
Flip default value for mypy disallow_untyped_defs [8/11] (#127845)
27f9d3b 
See #127836 for details.

Pull Request resolved: #127845
Approved by: https://github.com/oulgen
ghstack dependencies: #127842, #127843, #127844
pytorchmergebot pushed a commit that referenced this pull request Jun 8, 2024
@aorenste @pytorchmergebot
Flip default value for mypy disallow_untyped_defs [9/11] (#127846)
8db9dfa 
See #127836 for details.

Pull Request resolved: #127846
Approved by: https://github.com/ezyang
ghstack dependencies: #127842, #127843, #127844, #127845
pytorchmergebot pushed a commit that referenced this pull request Jun 8, 2024
@aorenste @pytorchmergebot
Flip default value for mypy disallow_untyped_defs [10/11] (#127847)
5753628 
See #127836 for details.

Pull Request resolved: #127847
Approved by: https://github.com/oulgen
ghstack dependencies: #127842, #127843, #127844, #127845, #127846
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@aorenste @TharinduRusira
Flip default value for mypy disallow_untyped_defs [5/11] (pytorch#127842
08b4ebb 
)

See pytorch#127836 for details.

Pull Request resolved: pytorch#127842
Approved by: https://github.com/oulgen
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@aorenste @TharinduRusira
Flip default value for mypy disallow_untyped_defs [6/11] (pytorch#127843
88aeaec 
)

See pytorch#127836 for details.

Pull Request resolved: pytorch#127843
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#127842
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@aorenste @TharinduRusira
Flip default value for mypy disallow_untyped_defs [7/11] (pytorch#127844
2eab9f6 
)

See pytorch#127836 for details.

Pull Request resolved: pytorch#127844
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#127842, pytorch#127843
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@aorenste @TharinduRusira
Flip default value for mypy disallow_untyped_defs [8/11] (pytorch#127845
5258b89 
)

See pytorch#127836 for details.

Pull Request resolved: pytorch#127845
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#127842, pytorch#127843, pytorch#127844
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@aorenste @TharinduRusira
Flip default value for mypy disallow_untyped_defs [9/11] (pytorch#127846
4f6dcc8 
)

See pytorch#127836 for details.

Pull Request resolved: pytorch#127846
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#127842, pytorch#127843, pytorch#127844, pytorch#127845
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@aorenste @TharinduRusira
Flip default value for mypy disallow_untyped_defs [10/11] (pytorch#12…
a1a417d 
…7847)

See pytorch#127836 for details.

Pull Request resolved: pytorch#127847
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#127842, pytorch#127843, pytorch#127844, pytorch#127845, pytorch#127846
@github-actions github-actions bot deleted the gh/aorenste/61/head branch July 9, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oulgen oulgen oulgen approved these changes

Assignees
No one assigned
Labels
ciflow/inductor Merged module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aorenste @oulgen @pytorchmergebot