-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip default value for mypy disallow_untyped_defs [9/11] #127846
Conversation
…for details. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127846
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6c456af with merge base 62bcdc0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the spirit of BE I'll approve this but I am a little suspicious that it is that easy to make files allow-untyped-defs clean, especially when you don't have accurate types for things you are calling
I suspect it will be an iterative process over time. The goal for this change is to try to prevent things from getting worse. |
The iteration is not the problem, it's just not clear to me that you can clean these files on eby one |
See #127836 for details. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
) See pytorch#127836 for details. Pull Request resolved: pytorch#127846 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#127842, pytorch#127843, pytorch#127844, pytorch#127845
…7847) See pytorch#127836 for details. Pull Request resolved: pytorch#127847 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#127842, pytorch#127843, pytorch#127844, pytorch#127845, pytorch#127846
See #127836 for details.
Stack from ghstack (oldest at bottom):
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10