Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip default value for mypy disallow_untyped_defs [9/11] #127846

Closed
wants to merge 2 commits into from

Conversation

Copy link

pytorch-bot bot commented Jun 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127846

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 6c456af with merge base 62bcdc0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of BE I'll approve this but I am a little suspicious that it is that easy to make files allow-untyped-defs clean, especially when you don't have accurate types for things you are calling

@aorenste
Copy link
Contributor Author

aorenste commented Jun 5, 2024

In the spirit of BE I'll approve this but I am a little suspicious that it is that easy to make files allow-untyped-defs clean, especially when you don't have accurate types for things you are calling

I suspect it will be an iterative process over time. The goal for this change is to try to prevent things from getting worse.

@aaronenyeshi aaronenyeshi removed their request for review June 5, 2024 18:23
@ezyang
Copy link
Contributor

ezyang commented Jun 5, 2024

The iteration is not the problem, it's just not clear to me that you can clean these files on eby one

@aorenste aorenste added the topic: not user facing topic category label Jun 5, 2024
See #127836 for details.




cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jun 8, 2024
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@github-actions github-actions bot deleted the gh/aorenste/65/head branch July 9, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: cpu CPU specific problem (e.g., perf, algorithm) release notes: package/deploy release notes category release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants