-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traceable FSDP2][Animesh's PR #125340] [dynamo][fsdp] Track FSDPNNModuleVariable for mutations #129045
Conversation
…ariable's param/buffer/submodule is mutated ghstack-source-id: 304e0000f1df32eea04b0de1319e9e6459b62227 Pull Request resolved: #129045
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this - #125340
Feel free to copy and open a PR if urgent. I can otherwise try to land it by Friday.
@@ -484,6 +516,17 @@ def test_fsdp_aot_eager(self): | |||
outputs = fsdp_m(inputs) | |||
self.assertTrue(same(correct_outputs, outputs)) | |||
|
|||
@skip_if_lt_x_gpu(1) | |||
@unittest.skipIf(not has_triton(), "Inductor+gpu needs triton and recent GPU arch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can xfail the test also, if nopython=True does not work today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or mabe remove nopython=True
and add a comment that we will work on it later.
ghstack-source-id: 75d0ce85eef6411fa890b37a7c5768440b98aa2e Pull Request resolved: #129045
@pytorchbot merge -f "unrelated failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This is a copy of Animesh's work in #125340, with very small changes to the unit test. It's needed sooner for the Traceable FSDP2 work, so I copy it here and will work through landing it.
Stack from ghstack (oldest at bottom):
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @chauhang @d4l3k @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng