Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch.dist for infinity, zero and minus infinity norms #13713

Closed
wants to merge 4 commits into from

Conversation

vishwakftw
Copy link
Contributor

@vishwakftw vishwakftw commented Nov 8, 2018

Fixes #13559

cc: @ssnl @zou3519

Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

edit: yes they pass

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Nov 8, 2018
Summary: Fixes #13559

Differential Revision: D12981556

Pulled By: zou3519

fbshipit-source-id: 99e86abab3ca045257374a9212ca24e7ca59fe9d
@zou3519
Copy link
Contributor

zou3519 commented Nov 8, 2018

Merged!

@zou3519 zou3519 closed this Nov 8, 2018
@vishwakftw vishwakftw deleted the dist-inf-minus-inf-fix branch November 10, 2018 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch.dist with inf or -inf norm always returns 1
5 participants