Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize Optional[T] to T (or subtype for Tensor) or None when executing graph #18407

Closed
wants to merge 26 commits into from
Closed

Specialize Optional[T] to T (or subtype for Tensor) or None when executing graph #18407

wants to merge 26 commits into from

Commits on Mar 24, 2019

  1. Specialize Optional (Tensor) to None when executing graph 

    In pytorch#18360, we used undefined Tensor (aka AutogradZeroTensor),
but this can be errorprone when the type or value is compared
to None, e.g. as seen when comined with the (not yet landed)

For this to work, we must allow None passed to functions
taking Tensor?.
    @t-vi
    t-vi committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    4ecb33a View commit details
    Browse the repository at this point in the history

  2. don't unpack NoneType in _unwrap_optional

    @t-vi
    t-vi committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    431edca View commit details
    Browse the repository at this point in the history

  3. fix worst stuff

    @t-vi
    t-vi committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    f557aeb View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    c032d5a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    60a3c93 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Fixes

    @t-vi
    t-vi committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    3b4acf9 View commit details
    Browse the repository at this point in the history

  2. incorporate some feedback from eellison, thanks

    @t-vi
    t-vi committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    e18cf4f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    6650d55 View commit details
    Browse the repository at this point in the history

  2. clean up specialize_autogradzero

    @t-vi
    t-vi committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    9cd8ac9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. add test for optional list

    @t-vi
    t-vi committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    c43e367 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2019

  1. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed Apr 6, 2019
    Configuration menu
    Copy the full SHA
    9b6bcd7 View commit details
    Browse the repository at this point in the history

  2. update hash for non-tensor args

    @t-vi
    t-vi committed Apr 6, 2019
    Configuration menu
    Copy the full SHA
    98dc52a View commit details
    Browse the repository at this point in the history

  3. remove CompleteArgumentSpec

    @t-vi
    t-vi committed Apr 6, 2019
    Configuration menu
    Copy the full SHA
    9e312df View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2019

  1. fix C++ argspec test, infer CompleteTensorTpe in _jit_pass_complete_s… 

    …hape_analysis
    @t-vi
    t-vi committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    2671e81 View commit details
    Browse the repository at this point in the history

  2. add TORCH_API for Windows

    @t-vi
    t-vi committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    fef2246 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. Implement feedback from zdevito

    @t-vi
    t-vi committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    3cd6ddf View commit details
    Browse the repository at this point in the history

  2. clean unwrapping, tabs

    @t-vi
    t-vi committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    3da9f1d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    87ff89b View commit details
    Browse the repository at this point in the history

  2. get_method? I don't know any methods. Oh, get_function you mean. You … 

    …should say so.
    @t-vi
    t-vi committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    9edcfcf View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Don't add None tensors to the argument stack 

    and assert that Optional tensors cannot be undefined.

Based on Zach's feedback. Thank you!
    @t-vi
    t-vi committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    7ec5ee5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed May 3, 2019
    Configuration menu
    Copy the full SHA
    08947d6 View commit details
    Browse the repository at this point in the history

  2. Deduplicate dimensioned tensor type creation. Thanks @eelison for the… 

    … suggestion
    @t-vi
    t-vi committed May 3, 2019
    Configuration menu
    Copy the full SHA
    66772ad View commit details
    Browse the repository at this point in the history

  3. fix tests - apparently we have no graph after error

    @t-vi
    t-vi committed May 3, 2019
    Configuration menu
    Copy the full SHA
    dcbfa67 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. improve tests, remove fixme

    @t-vi
    t-vi committed May 4, 2019
    Configuration menu
    Copy the full SHA
    7a4878d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into optional_None

    @t-vi
    t-vi committed May 4, 2019
    Configuration menu
    Copy the full SHA
    729517f View commit details
    Browse the repository at this point in the history

Commits on May 5, 2019

  1. add WithInsertPoint

    @t-vi
    t-vi committed May 5, 2019
    Configuration menu
    Copy the full SHA
    8b947f2 View commit details
    Browse the repository at this point in the history